Add copyright source headers and GHA check #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenSandwich
requested review from
prestonbourne
and removed request for
a team
Vercel Previews Deployed
|
RubenSandwich
changed the title
Comment on lines
+4
to
+5
| license = "BUSL-1.1" | ||
| copyright_year = 2024 |
There was a problem hiding this comment.
In the ticket it says the license should be BSL-1.1. Which one is correct and can the wrong one be updated? Also, should the copyright_year be 2025?
There was a problem hiding this comment.
@LeahMarieBush Looks like it is BUSL-1.1, at least if we use the terraform repo as a source of truth:
- https://github.com/hashicorp/terraform/blob/main/internal/builtin/providers/terraform/data_source_state.go#L2
- https://github.com/hashicorp/terraform/blob/main/.copywrite.hcl#L4
Good question; you usually copyright when you start work, not when you release:
LeahMarieBush
approved these changes
Mar 3, 2025
im2nguyen
pushed a commit
that referenced
this pull request
Mar 6, 2025
* Add copyright source headers * Add check headers GHA * Use a trusted checkout action version * test by pushing up a file with no header * forgot the .js on the file * Remove test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing GHA