Skip to content

Updated docs mocks to reconcile with updated framework docs #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

im2nguyen
Copy link
Collaborator

@im2nguyen im2nguyen commented Mar 3, 2025

🎟️ Asana

This PR updates the docs mock and latest version (1.14.x) for the terraform-plugin-framework docs. This was out-of-synced when @RubenSandwich resynced the docs in preparation for tomorrow's release.

Testing steps: run npm test or check GHA passing test


@im2nguyen im2nguyen requested a review from a team as a code owner March 3, 2025 21:13
@im2nguyen im2nguyen requested review from EnMod and removed request for a team March 3, 2025 21:13
Copy link

github-actions bot commented Mar 3, 2025

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Mar 4, 2025, 2:51 PM
Unified Docs API ✅ Ready (Inspect) Visit Preview Mar 4, 2025, 2:41 PM

@im2nguyen im2nguyen requested review from a team and LeahMarieBush and removed request for a team March 3, 2025 21:25
Copy link
Contributor

@RubenSandwich RubenSandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that this isn't just going to break again when we release terraform-plugin-framework v1.15.x.

Can you try copying over terraform-plugin-framework v1.14.x to a terraform-plugin-framework v1.15.x folder and see if these changes work? My hunch is that they will not.

We need to find a better way to mock this.

@im2nguyen
Copy link
Collaborator Author

@RubenSandwich I updated the test to use a mocked getProductVersion (defaults to 1.14.x -- matches our current mocked file)

Created 1.15.x directory in /content, ran npm run dev (to generate docsPathsAllVersions.json), then ran npm test. All tests pass successfully! Also tested with 1.16.x

Copy link
Contributor

@RubenSandwich RubenSandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@RubenSandwich RubenSandwich merged commit 8218aed into main Mar 4, 2025
6 checks passed
im2nguyen added a commit that referenced this pull request Mar 6, 2025
* updated docs mocks to reconcile with updated framework docs

* update allDocsPaths so its more flexible

---------

Co-authored-by: Ruben Nic <RubenSandwich@users.noreply.github.com>
@RubenSandwich RubenSandwich deleted the fix-test-resync-plugin-framework branch March 6, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants