-
Notifications
You must be signed in to change notification settings - Fork 10
Update run task timeout explanation #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
55bf491
to
5b232a1
Compare
Vercel Previews Deployed
|
Ping @rkoron007 as I believe you're still my docs reviewer for HCP TF Run Tasks stuff. |
Broken Link CheckerNo broken links found! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions
content/terraform-docs-common/docs/cloud-docs/api-docs/run-tasks/run-tasks-integration.mdx
Outdated
Show resolved
Hide resolved
content/terraform-docs-common/docs/cloud-docs/integrations/run-tasks/index.mdx
Outdated
Show resolved
Hide resolved
content/terraform-docs-common/docs/cloud-docs/integrations/run-tasks/index.mdx
Outdated
Show resolved
Hide resolved
0c454fe
to
2e98bdb
Compare
@trujillo-adam All suggestions commited. Thankyou for those! |
Hrmmm.... weird error happening.... @trujillo-adam any idea what's causing this?
|
@glennsarti So, we now have a link checker! 🎉 The error is saying that in the Anyways, this is all good to go! |
This commit just updates the table whitespace in the markdown file. No change to docs rendering.
The Run Task timeout behaviour has now changed from a fixed 10 minutes to "No progress update in the last 10 minutes, to a maximum runtime of 60 minutes" This commit updates the TFC docs to reflect this.
…-tasks/index.mdx Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
…ks/run-tasks-integration.mdx Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
…-tasks/index.mdx Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
2e98bdb
to
f55551e
Compare
@rkoron007 I had to change the link in the doc to not use the redirected link. No matter what I did the link checker would fail. Unfortunatley the 404 means it's not a timeout, it's that the end link doesn exist and since I didn't change anything on that side I have no idea how else to resolve the problem. |
@glennsarti But the link checker says there are no broken links! You fixed it!
|
@rkoron007 or @trujillo-adam would appreciate a ✅ so I can merge |
What and Why
The Run Task timeout behaviour has now changed from a fixed 10 minutes to
"No progress update in the last 10 minutes, to a maximum runtime of 60 minutes"
This commit updates the TFC docs to reflect this.
Merge Checklist
If items do not apply to your changes, add (N/A) and mark them as complete.
Pull Request
Content
website/redirects.js
for moved, renamed, or deleted pages.Reviews