Skip to content

Feat(TS): experimental middleware #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Feat(TS): experimental middleware #1544

wants to merge 7 commits into from

Conversation

grutt
Copy link
Contributor

@grutt grutt commented Apr 14, 2025

Description

It is often desirable to perform transformations to the input or output of a task or all task on a client.

For example:

  1. payload thinning
  2. encryption
  3. enrichment with no-serializable data

This experimental feature exposes a middleware concept that is applied to the inputs and outputs at runtime and on run method bindings.

It is available on the 1.2.0-alpha tag.

Type of change

  • New feature (non-breaking change which adds functionality)

Example usage:

/* eslint-disable max-classes-per-file */
/* eslint-disable max-classes-per-file */
import { JsonObject } from '@hatchet/v1/types';
import { Serializable, Middleware } from '@hatchet/v1/next';
import { HatchetClient } from '../../client/client';

class EncodeSerializer implements Serializable<unknown> {
  deserialize(input: JsonObject) {
    console.log('client-encode-deserialize', input);

    if (input.encoded && typeof input.encoded === 'string') {
      console.warn('WARNING THIS IS NOT REAL ENCRYPTION');
      const decoded = Buffer.from(input.encoded, 'base64').toString('utf-8');
      return JSON.parse(decoded);
    }

    return input;
  }

  serialize(input: unknown) {
    console.warn('WARNING THIS IS NOT REAL ENCRYPTION');
    const encoded = Buffer.from(JSON.stringify(input)).toString('base64');
    console.log('client-encode-serialize', input);
    return {
      encoded,
    };
  }
}

class EncodeMiddleware implements Middleware {
  input = new EncodeSerializer();
  output = new EncodeSerializer();
}

export const hatchet = HatchetClient.init({
  middleware: [new EncodeMiddleware()],
});

Copy link

vercel bot commented Apr 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 4:36pm
hatchet-v0-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 4:36pm

@grutt grutt requested a review from Copilot April 14, 2025 16:12
@grutt grutt marked this pull request as draft April 14, 2025 16:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • sdks/typescript/package.json: Language not supported
Comments suppressed due to low confidence (2)

sdks/typescript/src/v1/next/middleware/middleware.ts:38

  • The function getDeserializeChain is used for both input and output middleware chains but only maps over m.input.deserialize. For output processing it should map over m.output.deserialize. Consider splitting this into separate functions for input and output.
const getDeserializeChain = (middleware: Middleware[]) => { return middleware.map((m) => m.input.deserialize); }

sdks/typescript/src/v1/next/middleware/middleware.ts:43

  • The function getSerializeChain is used for composing the output serialization chain but currently maps over m.input.serialize. It should instead map over m.output.serialize to correctly process output data.
const getSerializeChain = (middleware: Middleware[]) => { return middleware.map((m) => m.input.serialize); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant