-
Notifications
You must be signed in to change notification settings - Fork 215
Feat(TS): experimental middleware #1544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
grutt
wants to merge
7
commits into
main
Choose a base branch
from
feat--middleware
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (1)
- sdks/typescript/package.json: Language not supported
Comments suppressed due to low confidence (2)
sdks/typescript/src/v1/next/middleware/middleware.ts:38
- The function getDeserializeChain is used for both input and output middleware chains but only maps over m.input.deserialize. For output processing it should map over m.output.deserialize. Consider splitting this into separate functions for input and output.
const getDeserializeChain = (middleware: Middleware[]) => { return middleware.map((m) => m.input.deserialize); }
sdks/typescript/src/v1/next/middleware/middleware.ts:43
- The function getSerializeChain is used for composing the output serialization chain but currently maps over m.input.serialize. It should instead map over m.output.serialize to correctly process output data.
const getSerializeChain = (middleware: Middleware[]) => { return middleware.map((m) => m.input.serialize); }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is often desirable to perform transformations to the input or output of a task or all task on a client.
For example:
This experimental feature exposes a middleware concept that is applied to the inputs and outputs at runtime and on run method bindings.
It is available on the
1.2.0-alpha
tag.Type of change
Example usage: