From c30b07437997f04848b72e7b8d262ca89e90b1d5 Mon Sep 17 00:00:00 2001 From: benk10 Date: Thu, 11 Apr 2024 19:23:22 +0300 Subject: [PATCH 1/2] Increase max hat fee split --- contracts/HATVaultsRegistry.sol | 2 +- test/hatvaults.js | 24 ++++++++++++------------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/contracts/HATVaultsRegistry.sol b/contracts/HATVaultsRegistry.sol index c5e3a0cd..f2b074ce 100644 --- a/contracts/HATVaultsRegistry.sol +++ b/contracts/HATVaultsRegistry.sol @@ -52,7 +52,7 @@ contract HATVaultsRegistry is IHATVaultsRegistry, Ownable { uint16 public constant HUNDRED_PERCENT = 10000; // the maximum percentage of the bounty that will be converted in HATs - uint16 public constant MAX_HAT_SPLIT = 2000; + uint16 public constant MAX_HAT_SPLIT = 3500; address public hatVaultImplementation; address public hatClaimsManagerImplementation; diff --git a/test/hatvaults.js b/test/hatvaults.js index b5a45d19..153fbfee 100644 --- a/test/hatvaults.js +++ b/test/hatvaults.js @@ -1233,22 +1233,22 @@ contract("HatVaults", (accounts) => { } try { - await claimsManager.setHATBountySplit(1000, 1001); - assert(false, "cannot set hat bounty split to more than 2000"); + await claimsManager.setHATBountySplit(1500, 2001); + assert(false, "cannot set hat bounty split to more than 3500"); } catch (ex) { assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit"); } try { - await claimsManager.setHATBountySplit(2001, 0); - assert(false, "cannot set hat bounty split to more than 2000"); + await claimsManager.setHATBountySplit(3501, 0); + assert(false, "cannot set hat bounty split to more than 3500"); } catch (ex) { assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit"); } try { - await claimsManager.setHATBountySplit(0, 2001); - assert(false, "cannot set hat bounty split to more than 2000"); + await claimsManager.setHATBountySplit(0, 3501); + assert(false, "cannot set hat bounty split to more than 3500"); } catch (ex) { assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit"); } @@ -1484,22 +1484,22 @@ contract("HatVaults", (accounts) => { ); try { - await hatVaultsRegistry.setDefaultHATBountySplit(2001, 0); - assert(false, "cannot set hat bounty split to more than 2000"); + await hatVaultsRegistry.setDefaultHATBountySplit(3501, 0); + assert(false, "cannot set hat bounty split to more than 3500"); } catch (ex) { assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit"); } try { - await hatVaultsRegistry.setDefaultHATBountySplit(0, 2001); - assert(false, "cannot set hat bounty split to more than 2000"); + await hatVaultsRegistry.setDefaultHATBountySplit(0, 3501); + assert(false, "cannot set hat bounty split to more than 3500"); } catch (ex) { assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit"); } try { - await hatVaultsRegistry.setDefaultHATBountySplit(1001, 1000); - assert(false, "cannot set hat bounty split to more than 2000"); + await hatVaultsRegistry.setDefaultHATBountySplit(1501, 2000); + assert(false, "cannot set hat bounty split to more than 3500"); } catch (ex) { assertVMException(ex, "TotalHatsSplitPercentageShouldBeUpToMaxHATSplit"); } From 952fa6d297fe0c1567698bad53a33575d1435c74 Mon Sep 17 00:00:00 2001 From: benk10 Date: Thu, 11 Apr 2024 19:27:11 +0300 Subject: [PATCH 2/2] Fix test --- docs/dodoc/tge/HATAirdrop.md | 2 +- test/hatvaults.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/dodoc/tge/HATAirdrop.md b/docs/dodoc/tge/HATAirdrop.md index 50e00dfa..9547c337 100644 --- a/docs/dodoc/tge/HATAirdrop.md +++ b/docs/dodoc/tge/HATAirdrop.md @@ -62,7 +62,7 @@ Initialize a HATAirdrop instance | _root | bytes32 | new merkle tree root to use for verifying airdrop data. | | _startTime | uint256 | start of the redeem period and of the token lock (if exists) | | _deadline | uint256 | end time to redeem from the contract | -| _lockEndTime | uint256 | end time for the token lock contract (if exists) | +| _lockEndTime | uint256 | end time for the token lock contract. If this date is in the past, the tokens will be transferred directly to the user and no token lock will be created | | _periods | uint256 | number of periods of the token lock contract (if exists) | | _token | contract IERC20Upgradeable | the token to be airdropped | | _tokenLockFactory | contract ITokenLockFactory | the token lock factory to use to deploy the token locks | diff --git a/test/hatvaults.js b/test/hatvaults.js index 153fbfee..4a1bc07e 100644 --- a/test/hatvaults.js +++ b/test/hatvaults.js @@ -921,8 +921,8 @@ contract("HatVaults", (accounts) => { arbitrator: accounts[2], maxBounty: maxBounty, bountySplit: bountySplit, - bountyGovernanceHAT: 1000, - bountyHackerHATVested: 1001, + bountyGovernanceHAT: 1500, + bountyHackerHATVested: 2001, vestingDuration: 86400, vestingPeriods: 10 }