Merge pull request #779 from hats-finance/fix/apy

fixed apy bug
hats-finance · Nov 26, 2024 · 5da7ff6 · 5da7ff6
2 parents ccd6d14 + 7ac6e6a
commit 5da7ff6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/web/src/hooks/vaults/useVaultApy.ts b/packages/web/src/hooks/vaults/useVaultApy.ts
@@ -56,7 +56,7 @@ export const useVaultApy = (vault?: IVault): IVaultApy[] => {
           vault.amountsInfo?.depositedAmount ? +vault.amountsInfo.depositedAmount.tokens : 0
         );
 
-        apys.push({ rewardController: controller, apy });
+        if (!isNaN(apy)) apys.push({ rewardController: controller, apy });
       }
 
       setVaultApys(apys);
@@ -87,7 +87,7 @@ function calculateAPY(
   // Calculate the APY
   // Note: vaultTokenStaked should be the total value of tokens staked in the vault
   // in the same currency as tokenPrice for an accurate APY calculation
-  const apy = (annualRewardValue / vaultTokenStaked) * 100;
+  const apy = vaultTokenStaked > 0 ? (annualRewardValue / vaultTokenStaked) * 100 : 0;
 
   return apy > 100 ? +apy.toFixed(0) : +apy.toFixed(2);
 }

diff --git a/...ultDetailsPage/Sections/VaultDepositsSection/VaultAssetsSection/components/VaultAsset.tsx b/...ultDetailsPage/Sections/VaultDepositsSection/VaultAssetsSection/components/VaultAsset.tsx
@@ -17,6 +17,7 @@ export const VaultAsset = ({ vault }: VaultAssetProps) => {
   const { isShowing: isShowingDepositModal, show: showDepositModal, hide: hideDepositModal } = useModal();
 
   const vaultApy = useVaultApy(vault);
+  console.log(vaultApy);
 
   const isAudit = vault.description && vault.description["project-metadata"].type === "audit";
   const depositsDisabled = !vault.committeeCheckedIn || vault.depositPause;