Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to morpho vault #631

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Changes to morpho vault #631

merged 1 commit into from
Jan 6, 2024

Conversation

fonstack
Copy link
Member

@fonstack fonstack commented Jan 6, 2024

Summary by CodeRabbit

- Bug Fix: Updated the project name to "Convergence Finance" for a specific vault address.
- New Feature: Changed the token icon for the Morpho vault to enhance visual representation.
- Refactor: Adjusted the `governanceHatRewardSplit` property of a particular vault to "2000" for better reward distribution.
- Chore: Modified the registered status and descriptionHash of the Morpho vault for improved data consistency.

Copy link

github-actions bot commented Jan 6, 2024

Image description CodeRabbit

Walkthrough

The changes primarily focus on updating specific vault properties in the overrideDescription and fixVaultsData functions. The updates include changing a project name, modifying an icon URL, adjusting a governance reward split, and altering registered status and descriptionHash for certain vaults.

Changes

File Summary
packages/web/src/hooks/subgraph/vaults/parser.ts The overrideDescription function now changes the project name to "Convergence Finance" for a specific vault address and updates the token icon for the Morpho vault. In fixVaultsData, the governanceHatRewardSplit property of a particular vault is updated to "2000", and the registered status and descriptionHash of the Morpho vault are modified.

🐇💻

Code changes here, code changes there,

Updating vaults with utmost care.

Convergence Finance takes the stage,

Morpho's icon turns a new page.

Governance rewards get a lift,

In our codebase, tectonic shift!

Registered status, descriptionHash,

Through lines of code, we deftly dash.

Celebrate these changes, big and small,

For they make our project stand tall! 🎉🥳


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

@fonstack fonstack requested a review from shayzluf January 6, 2024 18:49
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 792bb7f and 32777f8 commits.
Files selected (1)
  • packages/web/src/hooks/subgraph/vaults/parser.ts (2)
Files skipped from review due to trivial changes (1)
  • packages/web/src/hooks/subgraph/vaults/parser.ts
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@shayzluf shayzluf merged commit 433c290 into develop Jan 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants