Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Morpho vault #632

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Changes to Morpho vault #632

merged 2 commits into from
Jan 6, 2024

Conversation

fonstack
Copy link
Member

@fonstack fonstack commented Jan 6, 2024

Summary by CodeRabbit

- New Feature: Updated the project name to "Convergence Finance" for a specific vault address.
- New Feature: Changed the token icon for the Morpho vault to a new URL.
- Refactor: Adjusted the `governanceHatRewardSplit` property of a specific vault to "2000".
- Refactor: Modified the registered status and descriptionHash of the Morpho vault.

These changes enhance the user interface by providing updated information and visuals for specific vaults.

Copy link

github-actions bot commented Jan 6, 2024

Image description CodeRabbit

Walkthrough

The changes primarily focus on updating specific vault properties in the parser.ts file. This includes modifying project names, token icons, governance reward splits, and registered statuses for certain vault addresses. These alterations do not seem to impact the overall logic or functionality of the code.

Changes

File Summary
packages/web/src/hooks/subgraph/vaults/parser.ts The overrideDescription function now changes a project's name to "Convergence Finance" and updates the Morpho vault's token icon URL if the vault address matches a specific value. In fixVaultsData, the governanceHatRewardSplit property of a particular vault is updated to "2000", and the registered status and descriptionHash of the Morpho vault are modified.

🐇💻

In the land of code, where the rabbits dwell,

Changes were made, as this PR will tell.

Vault properties tweaked, with precision and care,

Ensuring the data is accurate and fair.

So let's celebrate these changes, small but keen,

In the ever-evolving world of the machine. 🎉🥕


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

@shayzluf shayzluf merged commit 8419755 into main Jan 6, 2024
4 of 5 checks passed
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 38a31a1 and 433c290 commits.
Files selected (1)
  • packages/web/src/hooks/subgraph/vaults/parser.ts (2)
Files skipped from review due to trivial changes (1)
  • packages/web/src/hooks/subgraph/vaults/parser.ts
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants