Skip to content

Commit f812793

Browse files
andcltlucashuymildanieljack-daviesdependabot[bot]
authored
Add nodejs20.x support (aws#67)
* Add nodejs20.x support * fix: Fix missing encoding when logging from Makefile (aws#535) * Fix missing encoding when logging from Makefile * Add comment explaining why stderr * Undo testing code * Version bump to 1.37.0 (aws#537) * Support PEP 600 platform tags for arm64 (aws#536) Co-authored-by: Daniel Mil <84205762+mildaniel@users.noreply.github.com> * chore(deps-dev): bump ruff from 0.0.284 to 0.0.287 in /requirements (aws#539) Bumps [ruff](https://github.com/astral-sh/ruff) from 0.0.284 to 0.0.287. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](astral-sh/ruff@v0.0.284...v0.0.287) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/checkout from 3 to 4 (aws#538) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump black from 23.3.0 to 23.7.0 in /requirements (aws#534) * chore(deps-dev): bump black from 23.3.0 to 23.7.0 in /requirements Bumps [black](https://github.com/psf/black) from 23.3.0 to 23.7.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@23.3.0...23.7.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update requirements/dev.txt --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> * chore(deps-dev): bump black from 23.7.0 to 23.9.1 in /requirements (aws#543) Bumps [black](https://github.com/psf/black) from 23.7.0 to 23.9.1. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@23.7.0...23.9.1) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump ruff from 0.0.287 to 0.0.288 in /requirements (aws#542) Bumps [ruff](https://github.com/astral-sh/ruff) from 0.0.287 to 0.0.288. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](astral-sh/ruff@v0.0.287...v0.0.288) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update pyelftools requirement in /requirements (aws#540) Updates the requirements on [pyelftools](https://github.com/eliben/pyelftools) to permit the latest version. - [Changelog](https://github.com/eliben/pyelftools/blob/master/CHANGES) - [Commits](eliben/pyelftools@v0.29...v0.30) --- updated-dependencies: - dependency-name: pyelftools dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump coverage from 7.2.7 to 7.3.1 in /requirements (aws#541) * chore(deps-dev): bump coverage from 7.2.7 to 7.3.1 in /requirements Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.2.7 to 7.3.1. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.2.7...7.3.1) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: set coverage versions based on python versions - since coverage 7.3.x python3.7 support has been dropped. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sriram Madapusi Vasudevan <srirammv@amazon.com> Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com> * chore: Version Bump 1.38.0 (aws#544) * chore(deps-dev): bump ruff from 0.0.288 to 0.0.290 in /requirements (aws#545) Bumps [ruff](https://github.com/astral-sh/ruff) from 0.0.288 to 0.0.290. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](astral-sh/ruff@v0.0.288...v0.0.290) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update github action to install nodejs 20 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Lucas <12496191+lucashuy@users.noreply.github.com> Co-authored-by: Daniel Mil <84205762+mildaniel@users.noreply.github.com> Co-authored-by: jack-davies <jck.davies@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> Co-authored-by: Sriram Madapusi Vasudevan <srirammv@amazon.com> Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com> Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com> Co-authored-by: Mohamed ElAsmar <melasmar@amazon.com>
1 parent 28becaf commit f812793

File tree

9 files changed

+70
-54
lines changed

9 files changed

+70
-54
lines changed

‎.github/workflows/build.yml

+13-13
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jobs:
6666
- "3.9"
6767
- "3.10"
6868
steps:
69-
- uses: actions/checkout@v3
69+
- uses: actions/checkout@v4
7070
- uses: actions/setup-python@v4
7171
with:
7272
python-version: ${{ matrix.python }}
@@ -94,13 +94,13 @@ jobs:
9494
- 8
9595
- 9
9696
steps:
97-
- uses: actions/checkout@v3
97+
- uses: actions/checkout@v4
9898
- uses: actions/setup-python@v4
9999
with:
100100
python-version: ${{ matrix.python }}
101101
- uses: actions/setup-node@v3
102102
with:
103-
node-version: 18
103+
node-version: 20
104104
- if: ${{ matrix.npm }}
105105
run: npm install -g npm@${{ matrix.npm }}
106106
- run: npm --version
@@ -127,13 +127,13 @@ jobs:
127127
- 8
128128
- 9
129129
steps:
130-
- uses: actions/checkout@v3
130+
- uses: actions/checkout@v4
131131
- uses: actions/setup-python@v4
132132
with:
133133
python-version: ${{ matrix.python }}
134134
- uses: actions/setup-node@v3
135135
with:
136-
node-version: 18
136+
node-version: 20
137137
- if: ${{ matrix.npm }}
138138
run: npm install -g npm@${{ matrix.npm }}
139139
- run: npm --version
@@ -157,7 +157,7 @@ jobs:
157157
- "3.10"
158158
- "3.11"
159159
steps:
160-
- uses: actions/checkout@v3
160+
- uses: actions/checkout@v4
161161
- uses: actions/setup-python@v4
162162
with:
163163
python-version: ${{ matrix.python }}
@@ -184,7 +184,7 @@ jobs:
184184
- "3.10"
185185
- "3.11"
186186
steps:
187-
- uses: actions/checkout@v3
187+
- uses: actions/checkout@v4
188188
- uses: actions/setup-python@v4
189189
with:
190190
python-version: ${{ matrix.python }}
@@ -214,7 +214,7 @@ jobs:
214214
- "3.10"
215215
- "3.11"
216216
steps:
217-
- uses: actions/checkout@v3
217+
- uses: actions/checkout@v4
218218
- uses: actions/setup-python@v4
219219
with:
220220
python-version: ${{ matrix.python }}
@@ -242,7 +242,7 @@ jobs:
242242
- "3.10"
243243
- "3.11"
244244
steps:
245-
- uses: actions/checkout@v3
245+
- uses: actions/checkout@v4
246246
- uses: actions/setup-python@v4
247247
with:
248248
python-version: ${{ matrix.python }}
@@ -266,7 +266,7 @@ jobs:
266266
- "3.10"
267267
- "3.11"
268268
steps:
269-
- uses: actions/checkout@v3
269+
- uses: actions/checkout@v4
270270
- uses: actions/setup-python@v4
271271
with:
272272
python-version: ${{ matrix.python }}
@@ -290,7 +290,7 @@ jobs:
290290
- "3.10"
291291
- "3.11"
292292
steps:
293-
- uses: actions/checkout@v3
293+
- uses: actions/checkout@v4
294294
- uses: actions/setup-python@v4
295295
with:
296296
python-version: ${{ matrix.python }}
@@ -320,7 +320,7 @@ jobs:
320320
- "3.10"
321321
- "3.11"
322322
steps:
323-
- uses: actions/checkout@v3
323+
- uses: actions/checkout@v4
324324
- uses: actions/setup-python@v4
325325
with:
326326
python-version: ${{ matrix.python }}
@@ -349,7 +349,7 @@ jobs:
349349
rust:
350350
- stable
351351
steps:
352-
- uses: actions/checkout@v3
352+
- uses: actions/checkout@v4
353353
- uses: actions/setup-python@v4
354354
with:
355355
python-version: ${{ matrix.python }}

‎.github/workflows/codeql.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242

4343
steps:
4444
- name: Checkout repository
45-
uses: actions/checkout@v3
45+
uses: actions/checkout@v4
4646

4747
# Initializes the CodeQL tools for scanning.
4848
- name: Initialize CodeQL

‎aws_lambda_builders/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44

55
# Changing version will trigger a new release!
66
# Please make the version change as the last step of your development.
7-
__version__ = "1.36.0"
7+
__version__ = "1.38.0"
88
RPC_PROTOCOL_VERSION = "0.3"

‎aws_lambda_builders/validator.py

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"nodejs14.x": [ARM64, X86_64],
1515
"nodejs16.x": [ARM64, X86_64],
1616
"nodejs18.x": [ARM64, X86_64],
17+
"nodejs20.x": [ARM64, X86_64],
1718
"python3.7": [X86_64],
1819
"python3.8": [ARM64, X86_64],
1920
"python3.9": [ARM64, X86_64],

‎aws_lambda_builders/workflows/custom_make/make.py

+11-2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import io
55
import logging
66
import shutil
7+
import sys
78
import threading
89

910
LOG = logging.getLogger(__name__)
@@ -92,9 +93,17 @@ def run(self, args, env=None, cwd=None):
9293

9394
# Log every stdout line by iterating
9495
for line in p.stdout:
95-
decoded_line = line.decode("utf-8").strip()
96-
LOG.info(decoded_line)
96+
# Writing to stderr instead of using LOG.info
97+
# since the logger library does not include ANSI
98+
# formatting characters in the output
99+
#
100+
# stderr is used since stdout appears to be reserved
101+
# for command responses
102+
sys.stderr.buffer.write(line)
103+
sys.stderr.flush()
104+
97105
# Gather total stdout
106+
decoded_line = line.decode("utf-8").strip()
98107
stdout += decoded_line
99108

100109
# Wait for the process to exit and stderr thread to end.

‎aws_lambda_builders/workflows/python_pip/packager.py

+1
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ class DependencyBuilder(object):
193193
_MANYLINUX_LEGACY_MAP = {
194194
"manylinux1_x86_64": "manylinux_2_5_x86_64",
195195
"manylinux2010_x86_64": "manylinux_2_12_x86_64",
196+
"manylinux2014_aarch64": "manylinux_2_17_aarch64",
196197
"manylinux2014_x86_64": "manylinux_2_17_x86_64",
197198
}
198199

‎requirements/dev.txt

+6-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
coverage==7.2.7
1+
coverage==7.2.7; python_version < '3.8'
2+
coverage==7.3.1; python_version >= '3.8'
23
flake8==3.3.0; python_version < '3.8'
34
flake8==3.8.4; python_version >= '3.8'
45
pytest-cov==4.1.0
@@ -8,8 +9,9 @@ isort>=4.2.5,<5; python_version < '3.8'
89
# Test requirements
910
pytest>=6.1.1
1011
parameterized==0.9.0
11-
pyelftools~=0.29 # Used to verify the generated Go binary architecture in integration tests (utils.py)
12+
pyelftools~=0.30 # Used to verify the generated Go binary architecture in integration tests (utils.py)
1213

1314
# formatter
14-
black==23.3.0
15-
ruff==0.0.284
15+
black==22.6.0; python_version < "3.8"
16+
black==23.9.1; python_version >= "3.8"
17+
ruff==0.0.290

‎tests/integration/workflows/nodejs_npm/test_nodejs_npm.py

+18-15
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def tearDown(self):
4141
shutil.rmtree(self.dependencies_dir)
4242
shutil.rmtree(self.temp_dir)
4343

44-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
44+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
4545
def test_builds_project_without_dependencies(self, runtime):
4646
source_dir = os.path.join(self.TEST_DATA_FOLDER, "no-deps")
4747

@@ -57,7 +57,7 @@ def test_builds_project_without_dependencies(self, runtime):
5757
output_files = set(os.listdir(self.artifacts_dir))
5858
self.assertEqual(expected_files, output_files)
5959

60-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
60+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
6161
def test_builds_project_without_manifest(self, runtime):
6262
source_dir = os.path.join(self.TEST_DATA_FOLDER, "no-manifest")
6363

@@ -75,7 +75,7 @@ def test_builds_project_without_manifest(self, runtime):
7575
mock_warning.assert_called_once_with("package.json file not found. Continuing the build without dependencies.")
7676
self.assertEqual(expected_files, output_files)
7777

78-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
78+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
7979
def test_builds_project_and_excludes_hidden_aws_sam(self, runtime):
8080
source_dir = os.path.join(self.TEST_DATA_FOLDER, "excluded-files")
8181

@@ -91,7 +91,7 @@ def test_builds_project_and_excludes_hidden_aws_sam(self, runtime):
9191
output_files = set(os.listdir(self.artifacts_dir))
9292
self.assertEqual(expected_files, output_files)
9393

94-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
94+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
9595
def test_builds_project_with_remote_dependencies(self, runtime):
9696
source_dir = os.path.join(self.TEST_DATA_FOLDER, "npm-deps")
9797

@@ -111,7 +111,7 @@ def test_builds_project_with_remote_dependencies(self, runtime):
111111
output_modules = set(os.listdir(os.path.join(self.artifacts_dir, "node_modules")))
112112
self.assertEqual(expected_modules, output_modules)
113113

114-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
114+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
115115
def test_builds_project_with_npmrc(self, runtime):
116116
source_dir = os.path.join(self.TEST_DATA_FOLDER, "npmrc")
117117

@@ -138,14 +138,17 @@ def test_builds_project_with_npmrc(self, runtime):
138138
("nodejs14.x", "package-lock"),
139139
("nodejs16.x", "package-lock"),
140140
("nodejs18.x", "package-lock"),
141+
("nodejs20.x", "package-lock"),
141142
("nodejs12.x", "shrinkwrap"),
142143
("nodejs14.x", "shrinkwrap"),
143144
("nodejs16.x", "shrinkwrap"),
144145
("nodejs18.x", "shrinkwrap"),
146+
("nodejs20.x", "shrinkwrap"),
145147
("nodejs12.x", "package-lock-and-shrinkwrap"),
146148
("nodejs14.x", "package-lock-and-shrinkwrap"),
147149
("nodejs16.x", "package-lock-and-shrinkwrap"),
148150
("nodejs18.x", "package-lock-and-shrinkwrap"),
151+
("nodejs20.x", "package-lock-and-shrinkwrap"),
149152
]
150153
)
151154
def test_builds_project_with_lockfile(self, runtime, dir_name):
@@ -172,7 +175,7 @@ def test_builds_project_with_lockfile(self, runtime, dir_name):
172175

173176
self.assertEqual(expected_files, output_files)
174177

175-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
178+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
176179
def test_fails_if_npm_cannot_resolve_dependencies(self, runtime):
177180
source_dir = os.path.join(self.TEST_DATA_FOLDER, "broken-deps")
178181

@@ -187,7 +190,7 @@ def test_fails_if_npm_cannot_resolve_dependencies(self, runtime):
187190

188191
self.assertIn("No matching version found for aws-sdk@2.997.999", str(ctx.exception))
189192

190-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
193+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
191194
def test_builds_project_with_remote_dependencies_without_download_dependencies_with_dependencies_dir(self, runtime):
192195
source_dir = os.path.join(self.TEST_DATA_FOLDER, "npm-deps")
193196

@@ -205,7 +208,7 @@ def test_builds_project_with_remote_dependencies_without_download_dependencies_w
205208
output_files = set(os.listdir(self.artifacts_dir))
206209
self.assertEqual(expected_files, output_files)
207210

208-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
211+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
209212
def test_builds_project_with_remote_dependencies_with_download_dependencies_and_dependencies_dir(self, runtime):
210213
source_dir = os.path.join(self.TEST_DATA_FOLDER, "npm-deps")
211214

@@ -235,7 +238,7 @@ def test_builds_project_with_remote_dependencies_with_download_dependencies_and_
235238
output_dependencies_files = set(os.listdir(os.path.join(self.dependencies_dir)))
236239
self.assertNotIn(expected_dependencies_files, output_dependencies_files)
237240

238-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
241+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
239242
def test_builds_project_with_remote_dependencies_without_download_dependencies_without_dependencies_dir(
240243
self, runtime
241244
):
@@ -256,7 +259,7 @@ def test_builds_project_with_remote_dependencies_without_download_dependencies_w
256259
output_files = set(os.listdir(self.artifacts_dir))
257260
self.assertEqual(expected_files, output_files)
258261

259-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
262+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
260263
def test_builds_project_without_combine_dependencies(self, runtime):
261264
source_dir = os.path.join(self.TEST_DATA_FOLDER, "npm-deps")
262265

@@ -283,7 +286,7 @@ def test_builds_project_without_combine_dependencies(self, runtime):
283286
output_dependencies_files = set(os.listdir(os.path.join(self.dependencies_dir)))
284287
self.assertNotIn(expected_dependencies_files, output_dependencies_files)
285288

286-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
289+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
287290
def test_build_in_source_with_download_dependencies(self, runtime):
288291
source_dir = os.path.join(self.temp_testdata_dir, "npm-deps")
289292

@@ -312,7 +315,7 @@ def test_build_in_source_with_download_dependencies(self, runtime):
312315
output_files = set(os.listdir(self.artifacts_dir))
313316
self.assertEqual(expected_files, output_files)
314317

315-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
318+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
316319
def test_build_in_source_with_download_dependencies_local_dependency(self, runtime):
317320
source_dir = os.path.join(self.temp_testdata_dir, "with-local-dependency")
318321

@@ -341,7 +344,7 @@ def test_build_in_source_with_download_dependencies_local_dependency(self, runti
341344
output_files = set(os.listdir(self.artifacts_dir))
342345
self.assertEqual(expected_files, output_files)
343346

344-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
347+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
345348
def test_build_in_source_with_download_dependencies_and_dependencies_dir(self, runtime):
346349
source_dir = os.path.join(self.temp_testdata_dir, "npm-deps")
347350

@@ -376,7 +379,7 @@ def test_build_in_source_with_download_dependencies_and_dependencies_dir(self, r
376379
output_files = set(os.listdir(self.artifacts_dir))
377380
self.assertEqual(expected_files, output_files)
378381

379-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
382+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
380383
def test_build_in_source_with_download_dependencies_and_dependencies_dir_without_combine_dependencies(
381384
self, runtime
382385
):
@@ -409,7 +412,7 @@ def test_build_in_source_with_download_dependencies_and_dependencies_dir_without
409412
output_files = set(os.listdir(self.artifacts_dir))
410413
self.assertEqual(expected_files, output_files)
411414

412-
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",)])
415+
@parameterized.expand([("nodejs12.x",), ("nodejs14.x",), ("nodejs16.x",), ("nodejs18.x",), ("nodejs20.x",)])
413416
def test_build_in_source_reuse_saved_dependencies_dir(self, runtime):
414417
source_dir = os.path.join(self.temp_testdata_dir, "npm-deps")
415418

0 commit comments

Comments
 (0)