Prisma fixes #452

haydenbleasel · 2025-02-16T19:03:15Z

This PR hopefully fixes a number of Prisma-related issues:

vercel · 2025-02-16T19:03:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
next-forge	🛑 Canceled (Inspect)			Feb 17, 2025 4:31pm
next-forge-api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 4:31pm
next-forge-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 4:31pm

barsketis · 2025-02-16T23:41:38Z

what is the build error in vercel for next-forge-app after this last commit?

haydenbleasel · 2025-02-16T23:48:51Z

Hey @barsketis, on the second-to-last commit, these were the build statuses:

✅ app
❌ api
✅ web

API had the warning:

.../node_modules/@prisma/client postinstall$ node scripts/postinstall.js
.../node_modules/@prisma/client postinstall: prisma:warn We could not find your Prisma schema in the default locations (see: https://pris.ly/d/prisma-schema-location).
.../node_modules/@prisma/client postinstall: If you have a Prisma schema file in a custom path, you will need to run
.../node_modules/@prisma/client postinstall: `prisma generate --schema=./path/to/your/schema.prisma` to generate Prisma Client.
.../node_modules/@prisma/client postinstall: If you do not have a Prisma schema file yet, you can ignore this message.
.../node_modules/@prisma/client postinstall: Done

it also had the error:

api:build: Failed to compile.
api:build:
api:build: ../../packages/database/index.ts:6:1
api:build: Module not found: Can't resolve './generated/client'
api:build: 4 | import { PrismaNeon } from '@prisma/adapter-neon';
api:build: 5 | import ws from 'ws';
api:build: > 6 | import { PrismaClient } from './generated/client';
api:build: | ^
api:build: 7 | import { keys } from './keys';
api:build: 8 |
api:build: 9 | const globalForPrisma = global as unknown as { prisma: PrismaClient };
api:build:
api:build: https://nextjs.org/docs/messages/module-not-found
api:build:
api:build: Import trace for requested module:
api:build: ./app/cron/keep-alive/route.ts
api:build:
api:build:
api:build: > Build failed because of webpack errors

On the latest commit:

❌ app
✅ api
✅ web

app has the error:

app:build: Failed to compile.
app:build:
app:build: ../../packages/database/index.ts:6:1
app:build: Module not found: Can't resolve './generated/client'
app:build: 4 | import { PrismaNeon } from '@prisma/adapter-neon';
app:build: 5 | import ws from 'ws';
app:build: > 6 | import { PrismaClient } from './generated/client';
app:build: | ^
app:build: 7 | import { keys } from './keys';
app:build: 8 |
app:build: 9 | const globalForPrisma = global as unknown as { prisma: PrismaClient };
app:build:
app:build: https://nextjs.org/docs/messages/module-not-found
app:build:
app:build: Import trace for requested module:
app:build: ./app/(authenticated)/page.tsx
app:build:
app:build:
app:build: > Build failed because of webpack errors

I'm thinking that last commit fixed the warning, but the ./generated/client issue feels either ephemeral or a race condition.

Possibly related is prisma/prisma#7234 (comment)

barsketis · 2025-02-17T00:40:49Z

Heres what I did to get the build to pass vercel, im not sure if this is optimal but might help

packages package.json

{
  "scripts": {
    "analyze": "prisma generate --no-hints --schema=./prisma/schema.prisma",
    "postinstall": "prisma generate --no-hints --schema=./prisma/schema.prisma",
    "build": "prisma generate --no-hints --schema=./prisma/schema.prisma",
    "clean": "git clean -xdf .cache .turbo dist node_modules",
    "typecheck": "tsc --noEmit --emitDeclarationOnly false"
  },
}

turbo.json modified the outputs to include the generated folder

{
  "$schema": "https://turbo.build/schema.json",
  "globalDependencies": ["**/.env.*local"],
  "ui": "tui",
  "envMode": "loose",
  "tasks": {
    "build": {
      "dependsOn": ["^build", "test"],
      "outputs": [".next/**", "!.next/cache/**", ".basehub/**", "**/generated/**"]
    },
  }
}

barsketis · 2025-02-17T02:44:03Z

The vercel build had prisma errors after loggin in

⨯ Error [PrismaClientInitializationError]: 
Invalid `prisma.page.findMany()` invocation:


Prisma Client could not locate the Query Engine for runtime "rhel-openssl-3.0.x".

I tried adding in the binary query engine in the prisma file, but it did not work, so I reverted your removal of the helper library installed (@prisma/nextjs-monorepo-workaround-plugin), and had to make some minor changes to get it to compile on vercel. It appears to be working now with no errors

import withBundleAnalyzer from "@next/bundle-analyzer"

import { PrismaPlugin } from "@prisma/nextjs-monorepo-workaround-plugin"
import type { NextConfig } from "next"

const otelRegex = /@opentelemetry\/instrumentation/

export const config: NextConfig = {
  images: {
    formats: ["image/avif", "image/webp"],
    remotePatterns: [
      {
        protocol: "https",
        hostname: "img.clerk.com",
      },
    ],
  },

  // biome-ignore lint/suspicious/useAwait: rewrites is async
  async rewrites() {
    return [
      {
        source: "/ingest/static/:path*",
        destination: "https://us-assets.i.posthog.com/static/:path*",
      },
      {
        source: "/ingest/:path*",
        destination: "https://us.i.posthog.com/:path*",
      },
      {
        source: "/ingest/decide",
        destination: "https://us.i.posthog.com/decide",
      },
    ]
  },

  webpack(config, { isServer }) {
    if (isServer) {
      config.plugins = config.plugins || []
      config.plugins.push(new PrismaPlugin())
    }

    config.ignoreWarnings = [{ module: otelRegex }]

    return config
  },

  // This is required to support PostHog trailing slash API requests
  skipTrailingSlashRedirect: true,
}

export const withAnalyzer = (sourceConfig: NextConfig): NextConfig =>
  withBundleAnalyzer()(sourceConfig)

DaveMitten · 2025-02-17T14:32:56Z

The vercel build had prisma errors after loggin in

⨯ Error [PrismaClientInitializationError]: 
Invalid `prisma.page.findMany()` invocation:


Prisma Client could not locate the Query Engine for runtime "rhel-openssl-3.0.x".

I tried adding in the binary query engine in the prisma file, but it did not work, so I reverted your removal of the helper library installed (@prisma/nextjs-monorepo-workaround-plugin), and had to make some minor changes to get it to compile on vercel. It appears to be working now with no errors

import withBundleAnalyzer from "@next/bundle-analyzer"

import { PrismaPlugin } from "@prisma/nextjs-monorepo-workaround-plugin"
import type { NextConfig } from "next"

const otelRegex = /@opentelemetry\/instrumentation/

export const config: NextConfig = {
  images: {
    formats: ["image/avif", "image/webp"],
    remotePatterns: [
      {
        protocol: "https",
        hostname: "img.clerk.com",
      },
    ],
  },

  // biome-ignore lint/suspicious/useAwait: rewrites is async
  async rewrites() {
    return [
      {
        source: "/ingest/static/:path*",
        destination: "https://us-assets.i.posthog.com/static/:path*",
      },
      {
        source: "/ingest/:path*",
        destination: "https://us.i.posthog.com/:path*",
      },
      {
        source: "/ingest/decide",
        destination: "https://us.i.posthog.com/decide",
      },
    ]
  },

  webpack(config, { isServer }) {
    if (isServer) {
      config.plugins = config.plugins || []
      config.plugins.push(new PrismaPlugin())
    }

    config.ignoreWarnings = [{ module: otelRegex }]

    return config
  },

  // This is required to support PostHog trailing slash API requests
  skipTrailingSlashRedirect: true,
}

export const withAnalyzer = (sourceConfig: NextConfig): NextConfig =>
  withBundleAnalyzer()(sourceConfig)

Does this mean that there has been a resolution in the build error for the prisma db issue, or are we needing further action?

haydenbleasel · 2025-02-17T14:36:11Z

@DaveMitten that change simply reverts my change, I don't think it will fix the issues linked.

I've asked the Prisma team to take a look.

haydenbleasel · 2025-02-17T14:38:37Z

Also for context, this PR implements Prisma's officially documented way of working with Turborepo. Unsure how the plugin fits into this but it would be nice to have better documentation.

ankur-arch · 2025-02-17T14:46:27Z

Hi @barsketis 👋 ,

Are you using a custom output path with the helper library?

barsketis · 2025-02-17T15:01:45Z

Hi @barsketis 👋 ,

Are you using a custom output path with the helper library?

Yes that is correct, I merged his branch in and added back the library to get rid of the binary issue during the vercel build, but I kept the generated client code. Otherwise prisma would not export the types and throw a "no page type found" during compiling the vanilla repo with vercel.

generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["driverAdapters"]
  output          = "../generated/client"
}

I do agree with hayden, the prisma documentation is not accurate for how to deal with turbo repos, I tried many different combinations they recommended and defaulted back to utilizing their helper library. Im not sure what this library does however, it might be redundant with haydens changes for the output file.

 webpack(config, { isServer }) {
    if (isServer) {
      config.plugins = config.plugins || []
      config.plugins.push(new PrismaPlugin())
    }

    config.ignoreWarnings = [{ module: otelRegex }]

    return config
  },

  // This is required to support PostHog trailing slash API requests
  skipTrailingSlashRedirect: true,
}

I havent tested this solution yet but it doesnt seem optimal.
prisma/prisma#22519

 "compilerOptions": {
    "paths": {
      "@prisma/client": ["./node_modules/@prisma/client"]
    }

barsketis · 2025-02-17T16:21:55Z

Here are the changes I did to get the App repo working on vercel
#453

…r, added generated outputs to turbo, and added next middleware type (#453)

haydenbleasel · 2025-02-17T16:31:13Z

Seems to deploy just fine now! Nice work @barsketis

github-actions · 2025-02-17T16:33:58Z

🚀 PR was released in v3.2.26 🚀

haydenbleasel added 2 commits February 16, 2025 13:59

Remove unused prisma/client from app

989c5b3

Replace nextjs-monorepo-workaround-plugin with specific client output

81c9b4c

vercel bot deployed to Preview – next-forge-app February 16, 2025 19:04 View deployment

vercel bot had a problem deploying to Preview – next-forge-api February 16, 2025 19:05 Failure

vercel bot deployed to Preview – next-forge February 16, 2025 19:05 View deployment

Update package.json

6ccf1fe

vercel bot deployed to Preview – next-forge-api February 16, 2025 19:37 View deployment

vercel bot deployed to Preview – next-forge February 16, 2025 19:38 View deployment

vercel bot had a problem deploying to Preview – next-forge-app February 16, 2025 19:40 Failure

barsketis and others added 3 commits February 17, 2025 11:21

Fixed build failure in PR #452, added back the prisma mono repo helpe…

d74a59a

…r, added generated outputs to turbo, and added next middleware type (#453)

Update pnpm-lock.yaml

81b961b

Update index.ts

d719eb4

vercel bot deployed to Preview – next-forge February 17, 2025 16:26 View deployment

vercel bot deployed to Preview – next-forge-api February 17, 2025 16:28 View deployment

vercel bot deployed to Preview – next-forge-app February 17, 2025 16:31 View deployment

haydenbleasel merged commit dcee038 into main Feb 17, 2025
8 checks passed

haydenbleasel deleted the prisma-fixes branch February 17, 2025 16:32

haydenbleasel mentioned this pull request Feb 17, 2025

Caching and Build Fails #408

Closed

github-actions bot added the released This issue/pull request has been released. label Feb 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prisma fixes #452

Prisma fixes #452

haydenbleasel commented Feb 16, 2025 •

edited

Loading

vercel bot commented Feb 16, 2025 •

edited

Loading

barsketis commented Feb 16, 2025

haydenbleasel commented Feb 16, 2025

barsketis commented Feb 17, 2025 •

edited

Loading

barsketis commented Feb 17, 2025

DaveMitten commented Feb 17, 2025

haydenbleasel commented Feb 17, 2025

haydenbleasel commented Feb 17, 2025

ankur-arch commented Feb 17, 2025

barsketis commented Feb 17, 2025 •

edited

Loading

barsketis commented Feb 17, 2025

haydenbleasel commented Feb 17, 2025

github-actions bot commented Feb 17, 2025

Prisma fixes #452

Prisma fixes #452

Conversation

haydenbleasel commented Feb 16, 2025 • edited Loading

vercel bot commented Feb 16, 2025 • edited Loading

barsketis commented Feb 16, 2025

haydenbleasel commented Feb 16, 2025

barsketis commented Feb 17, 2025 • edited Loading

barsketis commented Feb 17, 2025

DaveMitten commented Feb 17, 2025

haydenbleasel commented Feb 17, 2025

haydenbleasel commented Feb 17, 2025

ankur-arch commented Feb 17, 2025

barsketis commented Feb 17, 2025 • edited Loading

barsketis commented Feb 17, 2025

haydenbleasel commented Feb 17, 2025

github-actions bot commented Feb 17, 2025

haydenbleasel commented Feb 16, 2025 •

edited

Loading

vercel bot commented Feb 16, 2025 •

edited

Loading

barsketis commented Feb 17, 2025 •

edited

Loading

barsketis commented Feb 17, 2025 •

edited

Loading