-
Notifications
You must be signed in to change notification settings - Fork 105
CORE-223 - Excluding CP leadership from high latency nodes #1658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-223 - Excluding CP leadership from high latency nodes #1658
Conversation
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far, a few thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @Rob-Hazelcast - a few comments from me
Co-authored-by: James Holgate <130981049+JamesHazelcast@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment of suggestions w.r.t wording for CP group recommendations, but otherwise LGTM - approving in advance
Co-authored-by: James Holgate <130981049+JamesHazelcast@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Made a small suggestion for consistency which you can action or ignore. Approving either way
Co-authored-by: Amanda Lindsay <v-amanda.lindsay@hazelcast.com>
https://hazelcast.atlassian.net/browse/CORE-223
Metric and phone home details TBC
Note: no updates to https://docs.hazelcast.com/hazelcast/6.0-snapshot/cp-subsystem/management or non-platform docs.