Skip to content

CORE-223 - Excluding CP leadership from high latency nodes #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 24, 2025

Conversation

Rob-Hazelcast
Copy link
Contributor

@Rob-Hazelcast Rob-Hazelcast commented Apr 11, 2025

@Rob-Hazelcast Rob-Hazelcast requested a review from a team as a code owner April 11, 2025 10:34
Copy link

netlify bot commented Apr 11, 2025

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 59639d5
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/680a62bc20b18e0008f572ff
😎 Deploy Preview https://deploy-preview-1658--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@gareth-johnston gareth-johnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far, a few thoughts.

Copy link
Contributor

@JamesHazelcast JamesHazelcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Rob-Hazelcast - a few comments from me

Rob-Hazelcast and others added 3 commits April 16, 2025 17:44
Co-authored-by: James Holgate <130981049+JamesHazelcast@users.noreply.github.com>
Copy link
Contributor

@JamesHazelcast JamesHazelcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment of suggestions w.r.t wording for CP group recommendations, but otherwise LGTM - approving in advance

Co-authored-by: James Holgate <130981049+JamesHazelcast@users.noreply.github.com>
Copy link
Contributor

@amandalindsay amandalindsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Made a small suggestion for consistency which you can action or ignore. Approving either way

Rob-Hazelcast and others added 2 commits April 22, 2025 14:20
Co-authored-by: Amanda Lindsay <v-amanda.lindsay@hazelcast.com>
@Rob-Hazelcast Rob-Hazelcast merged commit 91247d6 into hazelcast:main Apr 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants