Skip to content

move_by should give feedback on whether the requested position is reached (or thought to be reached). #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hello-robot-shehab opened this issue Apr 2, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@hello-robot-shehab
Copy link
Contributor

In /stretch_mujoco_simulator.py, the move_by command is a non-blocking function. When the user sends a move_by command, there is no blocking call or feedback whether the robot has moved.

We need either a timeout (similar to move_to's) to block until the robot reaches the position, or a different mechanism for the user to check if the desired position has been reached (without having to implement the logic themselves).

We also need to amend the docstrings since the timeout argument is not operational.

Image

@hello-robot-shehab hello-robot-shehab added the enhancement New feature or request label Apr 2, 2025
@hello-binit
Copy link
Contributor

The blocking move_to() is actually a departure from the real robot's API. For Stretch Body, move_to() is non-blocking, and there's a wait_command() method if you want to wait til completion. As you've noted, move_by() is non-blocking, and therefore matches the real API better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants