feat: update for vue3

hellof2e · Aug 13, 2024 · 3444a07 · 3444a07
1 parent 2d170a0
commit 3444a07
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 20 deletions.
diff --git a/packages/core/src/load.js b/packages/core/src/load.js
@@ -1,7 +1,5 @@
-// import * as Vue from 'vue'
-import Vue from 'vue'
-import App from 'virtual:vue-inspector-path:Overlay.vue'
 import inspectorOptions from 'virtual:vue-inspector-options'
+import App from 'virtual:vue-inspector-path:Overlay.vue'
 
 const CONTAINER_ID = 'vue-inspector-container'
 
@@ -15,29 +13,21 @@ function createInspectorContainer() {
   return el
 }
 
-function load() {
+async function load() {
   const isClient = typeof window !== 'undefined'
   if (!isClient)
     return
   createInspectorContainer()
   const { vue } = inspectorOptions
+  // console.log('load inspectorOptions', vue, `loadVue${vue}`)
 
-  console.log('load inspectorOptions', inspectorOptions)
+  let res = {}
+  if (vue === 3)
+    res = await import('./loadVue3.js')
+  else
+    res = await import('./loadVue2.js')
 
-  // vue 2/3 compatibility
-  vue === 3
-    ? Vue.createApp({
-      render: () => Vue.h(App),
-      devtools: {
-        hide: true,
-      },
-    }).mount(`#${CONTAINER_ID}`)
-    : new Vue({
-      render: h => h(App),
-      devtools: {
-        hide: true,
-      },
-    }).$mount(`#${CONTAINER_ID}`)
+  res.loadVue(CONTAINER_ID, App)
 }
 
 if (inspectorOptions.lazyLoad)

diff --git a/packages/core/src/loadVue2.js b/packages/core/src/loadVue2.js
@@ -0,0 +1,10 @@
+import Vue from 'vue'
+
+export function loadVue(CONTAINER_ID, App) {
+  new Vue({
+    render: h => h(App),
+    devtools: {
+      hide: true,
+    },
+  }).$mount(`#${CONTAINER_ID}`)
+}
diff --git a/packages/core/src/loadVue3.js b/packages/core/src/loadVue3.js
@@ -0,0 +1,10 @@
+import * as Vue from 'vue'
+
+export function loadVue(CONTAINER_ID, App) {
+  Vue.createApp({
+    render: () => Vue.h(App),
+    devtools: {
+      hide: true,
+    },
+  }).mount(`#${CONTAINER_ID}`)
+}
diff --git a/packages/playground/vue3/vite.config.ts b/packages/playground/vue3/vite.config.ts
@@ -9,7 +9,6 @@ export default defineConfig({
     Vue(),
     VueJsx(),
     Inspector({
-      enabled: true,
       toggleButtonVisibility: 'always',
       launchEditor: 'code',
     }),