Merge pull request #123 from griffithben/fix/v2-setting-assignee-conf…

…usion

Refactor method names to reflect functionality for assigning convos

composer.json

@@ -36,7 +36,7 @@
     "scripts": {
         "analyse": "vendor/bin/phpstan analyse src tests --level=5",
         "fix": "vendor/bin/php-cs-fixer fix --allow-risky=yes",
-        "sniff": "vendor/bin/php-cs-fixer fix --allow-risky=yes --dry-run --stop-on-violation",
+        "sniff": "vendor/bin/php-cs-fixer fix --allow-risky=yes --dry-run --stop-on-violation --verbose",
         "phpunit": "vendor/bin/phpunit",
         "phpunit:clover": "vendor/bin/phpunit --coverage-clover build/logs/clover.xml",
         "test": ["@sniff", "@analyse", "@phpunit"],

src/Conversations/Conversation.php

@@ -614,6 +614,7 @@ public function isAssigned(): bool
     public function setAssignee(?User $assignee): Conversation
     {
         $this->assignee = $assignee;
+        $this->setAssignTo($assignee->getId());
 
         return $this;
     }

tests/Conversations/ConversationTest.php

@@ -167,7 +167,7 @@ public function testExtract()
         $conversation->setId(12);
         $conversation->setNumber(3526);
         $conversation->setThreadCount(2);
-        $conversation->setAssignTo(2942);
+        $conversation->setAssignTo(9865);
         $conversation->withAutoRepliesEnabled();
         $conversation->setType('email');
         $conversation->setImported(true);
@@ -239,7 +239,7 @@ public function testExtract()
             'threadCount' => 2,
             'autoReply' => true,
             'type' => 'email',
-            'assignTo' => 2942,
+            'assignTo' => 9865,
             'imported' => true,
             'folderId' => 132,
             'status' => 'closed',
@@ -335,6 +335,20 @@ public function testExtractNewEntity()
         ], $conversation->extract());
     }
 
+    /**
+     * See https://github.com/helpscout/helpscout-api-php/issues/111.
+     */
+    public function testSettingAssigneeAlsoSetsAssignToId()
+    {
+        $convo = new Conversation();
+
+        $assignee = new User();
+        $assignee->setId(41);
+        $convo->setAssignee($assignee);
+
+        $this->assertSame($assignee->getId(), $convo->getAssignTo());
+    }
+
     public function testChatConvo()
     {
         $convo = new ChatConversation();
@@ -376,7 +390,9 @@ public function testStatusMethods()
         $this->assertNull($convo->getAssignee());
         $this->assertFalse($convo->isAssigned());
 
-        $convo->assignTo(new User());
+        $user = new User();
+        $user->setId(1);
+        $convo->assignTo($user);
         $this->assertTrue($convo->isAssigned());
 
         $convo->publish();