Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to improve the tests #151

Open
endersoncosta opened this issue Jul 28, 2022 · 3 comments
Open

We need to improve the tests #151

endersoncosta opened this issue Jul 28, 2022 · 3 comments
Labels
hacktoberfest question Further information is requested

Comments

@endersoncosta
Copy link
Contributor

Today the tests are too superficial, seeing this, we need to improve this to test the generated project, not only test the command as we do today...

What you think?
@endersoncosta endersoncosta added the question Further information is requested label Jul 28, 2022
@jhomarolo
Copy link
Contributor

I agree 100% with you, I think the cli structurally needs two things:

1 - A considerable refactor, it's full of code smells
2 - A test coverage that actually gives us a guarantee of safe change

@italojs
Copy link
Member

italojs commented Aug 6, 2022

I think a refactor could be more interesting at this moment, increasing the test coverage will generate more work in the future with the current code

@dalssoft
Copy link
Member

dalssoft commented Sep 4, 2022

I would suggest a massive refactoring with some structural changes:

  1. have a plugin architecture
  2. move the generators, templates, etc to the plugins
  3. move most of the tests to the plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dalssoft @endersoncosta @jhomarolo @italojs