Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: migrate plugin to oclif/core v2 #85

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Conversation

k80bowman
Copy link
Contributor

@k80bowman k80bowman commented Jan 22, 2025

Work item

Migrates the plugin to oclif/core v2. Also includes the following changes:

  • updates the engine to Node 20
  • updates the scripts
  • updates dependencies (eslint, Typescript, etc)
  • updates/adds tests
  • updates examples
  • adds test coverage reporting
  • updates github workflows
  • adds bin files for easier local testing

Testing

  • pull down this branch and run yarn && yarn build
  • Link the plugin to your CLI installation by running heroku plugins:link from the root directory of this repo
  • Run heroku api GET apps/APP_NAME. You should see details about your app
  • Using an app with a dyno, run printf '{"updates":[{"type":"web", "quantity":2}]}' | heroku api POST /apps/APP_NAME/formation. You should see that the quantity of web dynos for that app is now set to two.
    • I was not able to write a unit test for this usage, so it is good to test it manually for now.

@k80bowman k80bowman requested a review from a team as a code owner January 22, 2025 22:18
Copy link
Contributor

@eablack eablack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Couple of minor comments, approving.

@k80bowman k80bowman merged commit aefb1f4 into main Jan 31, 2025
7 checks passed
@k80bowman k80bowman deleted the k80/migrate-to-oclif-core branch January 31, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants