fix: nunjucks/code blocks in HTML comments were incorrectly converted

[D-Sketon]

What does it do?

fix #5433

Screenshots

Pull request tasks

• Add test cases for the changes.
• Passed the CI test.

[github-actions]

How to test

git clone -b fix/comment https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test

[coveralls]

Pull Request Test Coverage Report for Build 13330592073

Details

• 50 of 50 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.003%) to 99.465%

---

Totals
Change from base Build 13299585829:	0.003%
Covered Lines:	9845
Relevant Lines:	9898

---

💛 - Coveralls

[D-Sketon]

maybe we can solve it in backtick_code_block.ts

[uiolee]

You are right. I forgot that the code block was processed before post render

[D-Sketon]

The negative lookbehind and negative lookahead /(?<!<!--[^(?:\-\->)]*?)^((?:[^\S\r\n]*>){0,3}[^\S\r\n]*)(`{3,}|~{3,})[^\S\r\n]*((?:.*?[^`\s])?)[^\S\r\n]*\n((?:[\s\S]*?\n)?)(?:(?:[^\S\r\n]*>){0,3}[^\S\r\n]*)\2[^\S\r\n]?(\n+|$)(?![^(?:<!\-\-)]*?-->)/gm caused a performance regression 😓

[uiolee]

You are right. I forgot that the code block was processed before post render

[uiolee]

It looks a bit weird. Your code repeatedly escape and restore comments in 'post' and 'backtick_code_block'.

Is it possible to work like 'backtick_code_block', escape comment before post render(and before 'backtick_code_block'), restore them at the end of post render.(I am assume that the comments should not be rendered at all. I am not sure if it is right.)

[D-Sketon]

This means we need to share the escaped cache on a per-post basis between before_post_render and post_render (either by mounting a stored on each post or maintaining a global map). I'm not sure if this will increase the complexity of the code, and whether holding the cache for a long time will affect garbage collection. However, regardless, I will give it a try.