Fix clean console #5629
Fix clean console #5629
Conversation
How to testgit clone -b fix-clean-console https://github.com/dimaslanjaka/hexo.git
cd hexo
npm install
npm test |
Pull Request Test Coverage Report for Build 13221663076Details
💛 - Coveralls |
|
@SukkaW need review |
| @@ -1 +1,3 @@ | |||
| #!/bin/sh | |||
|
|
|||
There was a problem hiding this comment.
https://github.com/typicode/husky/releases/tag/v9.0.1#:~:text=shebang
shebang is not needed after husky v9
There was a problem hiding this comment.
but got error on my windows, see the screenshoot
There was a problem hiding this comment.
git scm windows version still need shebang. and shebang still allowed by husky. here the doc, Note section
There was a problem hiding this comment.
I could see your screenshot of error. However, I could not reproduce on my window.
| @@ -2,7 +2,8 @@ import Promise from 'bluebird'; | |||
| import { exists, unlink, rmdir } from 'hexo-fs'; | |||
| import type Hexo from '../../hexo'; | |||
|
|
|||
| function cleanConsole(this: Hexo): Promise<[void, void, any]> { | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
There was a problem hiding this comment.
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
Even if I delete it, eslint have not report any errors.
|
I can't reproduce the two questions you mentioned, hexo ci also shows normal. I'll suspect the problem comes from your operating environment |
What does it do?
#!/bin/sh, otherwise should got error like below screenshootPull request tasks