Skip to content

Commit 623520c

Browse files
fixes
1 parent 95d421f commit 623520c

File tree

6 files changed

+34
-20
lines changed

6 files changed

+34
-20
lines changed

src/components/emoji-picker.tsx

+7-11
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { Toggle } from "@/primitives/toggle";
99
import { useDoc } from "@/queries/docs";
1010
import { cn } from "@/lib/utils";
1111
import { REVALIDATE_DAY } from "@/lib/fetch";
12+
import { Button } from "@/primitives/button";
1213

1314
type EmojiPickerProps = {
1415
docId: string;
@@ -34,33 +35,28 @@ export const EmojiPicker = ({
3435
.json();
3536
return res;
3637
},
37-
persister: undefined,
3838
staleTime: REVALIDATE_DAY,
3939
});
4040

4141
return (
4242
<Popover open={isOpen} onOpenChange={setIsOpen}>
4343
<PopoverTrigger asChild>
44-
<Toggle
45-
pressed={isOpen}
46-
onPressedChange={setIsOpen}
47-
onClick={(e: React.MouseEvent<HTMLButtonElement>) => {
48-
e.preventDefault();
49-
e.stopPropagation();
50-
setIsOpen(!isOpen);
51-
}}
52-
data-emoji
44+
<Button
45+
size="icon"
46+
variant="ghost"
47+
onClick={() => setIsOpen(!isOpen)}
5348
className={cn(
5449
"h-9 w-9 rounded-lg bg-gray-3 dark:bg-gray-2 p-px !text-base",
5550
disabled && "pointer-events-none",
5651
className,
5752
)}
5853
>
5954
{emoji || "📝"}
60-
</Toggle>
55+
</Button>
6156
</PopoverTrigger>
6257
<PopoverContent
6358
align="start"
59+
side="bottom"
6460
avoidCollisions={true}
6561
className="w-[350px] overflow-hidden border-0 p-0"
6662
>

src/components/tiptap/tiptap-editor.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export const TipTapEditor = ({
121121
}
122122
});
123123

124-
if (mentionNodes.length === 0) return;
124+
console.log(prevMentionNodes, mentionNodes);
125125

126126
previousState.current = editor.state;
127127

@@ -131,7 +131,7 @@ export const TipTapEditor = ({
131131
}
132132
});
133133
},
134-
[removeBacklink, doc.id],
134+
[removeBacklink],
135135
);
136136

137137
/**

src/pages/login.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export async function getServerSideProps(ctx: GetServerSidePropsContext) {
2828
return {
2929
redirect: {
3030
permanent: false,
31-
destination: isOnboarded ? "/app" : "/onboarding",
31+
destination: isOnboarded ? "/" : "/onboarding",
3232
},
3333
};
3434

src/primitives/button.tsx

+8-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ export interface ButtonProps
4040
}
4141

4242
const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
43-
({ className, variant, size, title, asChild = false, ...props }, ref) => {
43+
(
44+
{ className, variant, size, onClick, title, asChild = false, ...props },
45+
ref,
46+
) => {
4447
const Comp = asChild ? Slot : "button";
4548

4649
if (title) {
@@ -49,7 +52,9 @@ const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
4952
<Comp
5053
className={cn(buttonVariants({ variant, size, className }))}
5154
ref={ref}
55+
onMouseDown={onClick}
5256
{...props}
57+
onClick={undefined}
5358
/>
5459
</Tooltip>
5560
);
@@ -59,7 +64,9 @@ const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
5964
<Comp
6065
className={cn(buttonVariants({ variant, size, className }))}
6166
ref={ref}
67+
onMouseDown={onClick}
6268
{...props}
69+
onClick={undefined}
6370
/>
6471
);
6572
},

src/primitives/toggle.tsx

+15-4
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,26 @@ const Toggle = React.forwardRef<
3333
React.ElementRef<typeof TogglePrimitive.Root>,
3434
React.ComponentPropsWithoutRef<typeof TogglePrimitive.Root> &
3535
VariantProps<typeof toggleVariants>
36-
>(({ className, variant, title, size, ...props }, ref) => (
37-
<Tooltip content={title}>
36+
>(({ className, variant, title, size, ...props }, ref) => {
37+
if (title) {
38+
return (
39+
<Tooltip content={title}>
40+
<TogglePrimitive.Root
41+
ref={ref}
42+
className={cn(toggleVariants({ variant, size, className }))}
43+
{...props}
44+
/>
45+
</Tooltip>
46+
);
47+
}
48+
return (
3849
<TogglePrimitive.Root
3950
ref={ref}
4051
className={cn(toggleVariants({ variant, size, className }))}
4152
{...props}
4253
/>
43-
</Tooltip>
44-
));
54+
);
55+
});
4556

4657
Toggle.displayName = TogglePrimitive.Root.displayName;
4758

src/primitives/tooltip.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export function Tooltip({
2525
...props
2626
}: TooltipProps) {
2727
return (
28-
<TooltipPrimitive.Root open={open} onOpenChange={onOpenChange}>
28+
<TooltipPrimitive.Root>
2929
<TooltipPrimitive.Trigger asChild>{children}</TooltipPrimitive.Trigger>
3030
<TooltipPrimitive.Content
3131
side={side}

0 commit comments

Comments
 (0)