chore: Small Helm and project improvements #1162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen deploying. adding mid-size.yaml for medium size deployments, usually what we deploy on dev k8 env. Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
… with the modules, keeps consistent aliases, and also are shown in the same order (alphabetical) so is easier to compare the 2 in the future Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
AlfredoG87
added
Helm - Deploy
Improvement
Nana-EC
reviewed
May 17, 2025
| @@ -1,7 +1,8 @@ | |||
| # 2 consumers | |||
| replicas: 2 | |||
| replicas: 1 | |||
There was a problem hiding this comment.
Q: Should this be changed?
Comment above still says 2 and I imagine have 2 consumers is valuable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
improving consumer override value, to avoid permission denied issue when deploying.
adding mid-size.yaml for medium size deployments, usually what we deploy on dev k8 env.
extra housekeeping of the settings.gradle.kts file, so it matches 1-1 with the modules, keeps consistent aliases, and also are shown in the same order (alphabetical) so is easier to compare the 2 in the future
Fixes #1161