-
Notifications
You must be signed in to change notification settings - Fork 81
fix: eth_sendRawTransaction now handles malformed RLP data correctly #3714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…re now handled correctly Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Test Results 26 files + 6 355 suites +105 53m 29s ⏱️ + 11m 3s For more details on these failures, see this check. Results for commit 2f948a1. ± Comparison against base commit b0c09bf. This pull request removes 1 and adds 89 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Thanks for the good work! LGTM
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
|
2f948a1
to
e3a2efb
Compare
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Description:
In this PR, the
eth_sendRawTransaction
logic now handles malformed RLP data correctly by checking for INVALID_ARGUMENT error and returning a predifined error and 400 status code.Related issue(s):
Fixes #3652
Checklist