fix: allowed callTracer to return empty array if no call actions found #3768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Test Results 22 files + 1 271 suites - 2 36m 52s ⏱️ + 3m 24s For more details on these failures, see this check. Results for commit 09ae045. ± Comparison against base commit fca86cc. ♻️ This comment has been updated with latest results. |
acuarica
previously approved these changes
May 15, 2025
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
force-pushed
the
3751-debug_tracetransaction-fails-with-some-specific-tx-hash
branch
from
ecea0d7 to
09ae045
Compare
acuarica
approved these changes
May 16, 2025
natanasow
approved these changes
May 16, 2025
quiet-node
deleted the
3751-debug_tracetransaction-fails-with-some-specific-tx-hash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR allows callTracer to return an empty array if no call actions are found, effectively preventing the deconstruction of an undefined object.
Related issue(s):
Fixes #3751
Notes for reviewer:
Checklist