fix: qr code show not found exception handling #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to enhance error handling in the
QrScannercomponent and adds extensive unit tests for Firebase-related functions. The most important changes include improved error messaging for QR code scanning, and the addition of unit tests for Firebase server functions and user data retrieval.Error handling improvements:
src/lib/components/QrScanner.svelte: Enhanced error messaging for QR code scanning by checking forNotFoundExceptionand providing more specific error messages. [1] [2]Unit tests for Firebase functions:
tests/firebase.test.ts: Added unit tests forgetGroupsData,getSessionData, andcheckRemoveParticipantPermissionfunctions, including mock implementations for Firestore interactions.tests/getUser.test.ts: Added unit tests for thegetUserfunction, including mock implementations for Firestore interactions and caching behavior.