Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix&style: conversation can't create when join existing group after started, improve layout #124

Merged
merged 5 commits into from
Dec 26, 2024

Conversation

howard9199
Copy link
Contributor

This pull request includes several changes to improve the layout and functionality of the chatroom and session components, as well as updates to the server-side logic for creating conversations and user sign-in. The most important changes include modifications to the Chatroom.svelte, HostView.svelte, and ParticipantView.svelte components, as well as updates to the Firebase server and sign-in API.

Improvements to chatroom layout:

Enhancements to session views:

Updates to server-side logic:

@howard9199 howard9199 self-assigned this Dec 26, 2024
@JacobLinCool JacobLinCool requested a review from Copilot December 26, 2024 16:16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/lib/components/Chatroom.svelte: Language not supported
  • src/lib/components/session/HostView.svelte: Language not supported
  • src/lib/components/session/ParticipantView.svelte: Language not supported
Comments suppressed due to low confidence (1)

src/lib/server/firebase.ts:47

  • The comment should be translated to English for consistency. Suggested translation: 'Check if a conversation already exists for the user'.
// 檢查是否已存在該使用者的對話
@howard9199 howard9199 changed the title fix&style: some users getUser has zoderror, improve layout fix&style: conversation can't create when join existing group after started, improve layout Dec 26, 2024
@howard9199 howard9199 merged commit c486a61 into main Dec 26, 2024
4 checks passed
@howard9199 howard9199 deleted the fix/some-user-getUser-zoderror branch December 26, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant