Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join session with code #49

Closed
wants to merge 2 commits into from
Closed

Join session with code #49

wants to merge 2 commits into from

Conversation

180079995
Copy link
Contributor

No description provided.

@JacobLinCool JacobLinCool requested review from howard9199 and Copilot and removed request for JacobLinCool December 22, 2024 18:56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • src/lib/components/session/HostView.svelte: Language not supported
  • src/routes/join/+page.svelte: Language not supported
Comments suppressed due to low confidence (1)

src/routes/api/session/+server.ts:56

  • [nitpick] The variable name 'Codes' is unconventional. It should be renamed to 'codes'.
let Codes = adminDb.collection('temp_codes').doc(code.toString());
@180079995 180079995 marked this pull request as draft December 22, 2024 19:17
@180079995 180079995 closed this Dec 22, 2024
@JacobLinCool JacobLinCool deleted the session-code branch February 20, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants