Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme typo #43

Closed
ncou opened this issue Aug 18, 2019 · 2 comments
Closed

Readme typo #43

ncou opened this issue Aug 18, 2019 · 2 comments

Comments

@ncou
Copy link

ncou commented Aug 18, 2019

Hi,

Nice piece of code. I think i have spotted a typoe in the readme file :

You can see the list of configs and files that plugin has detected and uses to build configs. It is located in vendor/hiqdev/composer-config-plugin/output/__files.php

It should be 'composer-config-plugin-output' and not 'composer-config-plugin/output'

NB : I think you should also add a check for illegal characters used in the filename for the config-plugin parameter, because if you use a name like this (using a '/' character) :

"config-plugin": { "foo/bar": [xxxxx

This will create a folder.

@SilverFire
Copy link
Member

Hello, @ncou.
Thank you for pointing it out!

It should be 'composer-config-plugin-output' and not 'composer-config-plugin/output'

Fixed

NB : I think you should also add a check for illegal characters used in the filename for the config-plugin parameter, because if you use a name like this (using a '/' character) :

Hmm... Need do discuss it with @hiqsol

@hiqsol
Copy link
Member

hiqsol commented Feb 3, 2020

This will create a folder.

Why is it a problem? I think it could be used on some purpose.

@hiqsol hiqsol closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants