Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate recursion #48

Closed
samdark opened this issue Jan 16, 2020 · 2 comments
Closed

Validate recursion #48

samdark opened this issue Jan 16, 2020 · 2 comments

Comments

@samdark
Copy link
Contributor

samdark commented Jan 16, 2020

Currently it's possible to cause recursion with a config:

https://github.com/viktorprogger/rss-telegram-bot/blob/cc07b693bdfe31a52bf249aac840daedc50440ec/src/composer.json

That would lead to

Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 20480 bytes) in D:\dev\delete_me\rss-telegram-bot\src\vendor\hiqdev\composer-config-plugin\src\Plugin.php on line 158

It would be good to check recursive configs in advance and error in a self-explanatory way instead.
@hiqsol
Copy link
Member

hiqsol commented Jan 17, 2020

First of all, it's senseless to include params in params cause it doesn't add anything.
But I will prevent infinite loop.

hiqsol added a commit that referenced this issue Jan 17, 2020
@hiqsol
Prevented infinite recursion in getAllFiles() #48
0ebcdea
@hiqsol
Copy link
Member

hiqsol commented Feb 3, 2020

Fixed in 0ebcdea

@hiqsol hiqsol closed this as completed Feb 3, 2020
@samdark samdark mentioned this issue May 10, 2020
Closed
xepozz pushed a commit to xepozz/hiqdev-fork-composer-config-plugin that referenced this issue May 20, 2020
@samdark
Fix hiqdev#48: Adjust finding path (hiqdev#51)
5f76666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samdark @hiqsol