Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config-plugin-output-dir doesn't work on Windows #51

Closed
samdark opened this issue Feb 20, 2020 · 2 comments
Closed

config-plugin-output-dir doesn't work on Windows #51

samdark opened this issue Feb 20, 2020 · 2 comments

Comments

@samdark
Copy link
Contributor

samdark commented Feb 20, 2020 •
edited
Loading

"config-plugin-output-dir": "runtime/build/config/", works well when generating files but fails when reading them (adds vendor to the path).

Since that's on Windows, it may be an issue alike 341d3ad.

Linux works well.
@samdark samdark mentioned this issue Feb 20, 2020
Closed
@samdark samdark changed the title config-plugin-output-dir doesn't work config-plugin-output-dir doesn't work on Windows Feb 20, 2020
@hiqsol
Copy link
Member

hiqsol commented Feb 21, 2020

I have no windows machine to test.
Could you please make PR? :)

@samdark
Copy link
Contributor Author

samdark commented Feb 21, 2020

Yes. I will check it.

@samdark samdark mentioned this issue Feb 21, 2020
Merged
@samdark samdark closed this as completed Feb 24, 2020
xepozz pushed a commit to xepozz/hiqdev-fork-composer-config-plugin that referenced this issue May 20, 2020
@samdark
Fix hiqdev#48: Adjust finding path (hiqdev#51)
5f76666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samdark @hiqsol