-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HP-1921: add new SearchMangedField
#169
Conversation
WalkthroughThe recent updates introduce enhancements to the mobile app assets management and refine the search functionality within the application. Asset paths have been redefined for better organization, and the search mechanism now supports additional attributes, improving query precision. The user interface for part searches has been refined with new widgets, offering a more intuitive and efficient user experience. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (3)
- src/assets/Mobile/MobileAppAsset.php (2 hunks)
- src/models/PartSearch.php (1 hunks)
- src/views/part/_search.php (5 hunks)
Additional comments not posted (6)
src/assets/Mobile/MobileAppAsset.php (2)
11-11
: Ensure the/dist
subdirectory exists and contains the necessary assets.
14-14
: Ensuremobile-app.js
exists in the/dist
subdirectory and is correctly implemented.src/models/PartSearch.php (2)
43-44
: Confirm that the attributes'dst_type_in'
and'device_location_leftLikei'
are supported by the underlying data model and search logic.
69-70
: Verify that translations for the labels'dst_type_in'
and'device_location_leftLikei'
exist and are correctly implemented.src/views/part/_search.php (2)
88-93
: Test theServerTypeRefCombo
widget in the UI to ensure it functions as expected and integrates well with the search form.
110-110
: Verify theSearchManagedField
widget's functionality and ensure it integrates correctly with the search logic, particularly thesearchBy
options.
Summary by CodeRabbit