HP-1581: fixed "explode(): Passing null to parameter #2 ($string) of type string is deprecated" error

[VadymHrechukha]

https://sentry.hiqdev.com/organizations/hiqdev/issues/57337/

Summary by CodeRabbit

• Bug Fixes
  • Improved robustness of the StockLocationsListTreeSelect component to handle null values more effectively, preventing potential errors.

[coderabbitai]

Walkthrough

The StockLocationsListTreeSelect class's init() method was improved by handling potential null values for $this->model->{$this->attribute}. This was achieved using the null coalescing operator ?? '', ensuring the StringHelper::explode() method is always called with a non-null value. This change enhances code robustness and prevents errors when the attribute is null.

Changes

File	Change Summary
src/widgets/StockLocationsListTreeSelect.php	Updated the init() method to handle potential null values using the null coalescing operator ?? ''.

Changes were grouped based on their functional similarity to keep the summary concise.

Poem

In the land where code does dwell,
A null was causing quite the spell.
With a sprinkle of ?? '' so neat,
Robustness now, a code's heartbeat.
Bugs and errors, now less seen,
A smoother run, in code serene.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fc45dc2 and 620b2cd.

Files selected for processing (1)

• src/widgets/StockLocationsListTreeSelect.php (1 hunks)

Additional comments not posted (1)

src/widgets/StockLocationsListTreeSelect.php (1)

44-44: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to StringHelper::explode match the new usage.

Verification successful

---

Verification successful.

The only instance of StringHelper::explode in the codebase matches the new usage.

• No further instances of StringHelper::explode were found that need updating.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `StringHelper::explode` match the new usage.

# Test: Search for the function usage. Expect: Only occurrences of the new usage.
rg --type php -A 5 $'StringHelper::explode'

Length of output: 505

---

Script:

#!/bin/bash
# Description: Verify all function calls to `StringHelper::explode` match the new usage across the entire codebase.

# Test: Search for the function usage. Expect: Only occurrences of the new usage.
rg --type php -A 5 $'StringHelper::explode'

Length of output: 505