HP-2134: add new location to mobile stock

[tafid]

Summary by CodeRabbit

• New Features
  • Expanded location data by adding a new entry: NL:AMS:DR:AMS3 to the locations response.

These changes enhance the information available to users when retrieving location data.

[coderabbitai]

Walkthrough

The pull request introduces a new location entry to the response of the actionGetLocations method in the MobileController.php file. The added entry is ['name' => 'NL:AMS:DR:AMS3'], which expands the list of locations returned by this method while maintaining the existing entries.

Changes

Files	Change Summary
src/controllers/MobileController.php	Added a new location entry ['name' => 'NL:AMS:DR:AMS3'] to the response of actionGetLocations.

Poem

In the code where bunnies hop,
A new location joins the crop.
'NL:AMS:DR:AMS3' takes its place,
Expanding routes in our embrace.
With every change, we leap and cheer,
More places to explore, oh dear! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/controllers/MobileController.php (1)

Line range hint 162-169: LGTM! Consider extracting locations to a configuration file.

The addition of the new location 'NL:AMS:DR:AMS3' is correct and aligns with the PR objective. The implementation is consistent with the existing structure and should not cause any backwards compatibility issues.

For improved maintainability, consider extracting the list of locations to a separate configuration file. This would make it easier to manage and update locations in the future without modifying the controller code. For example:

public function actionGetLocations(): Response
{
    return $this->response(Yii::$app->params['mobileStockLocations']);
}

Then, define the locations in a configuration file:

return [
    'mobileStockLocations' => [
        ['name' => 'NL:AMS:EQ:AM7'],
        ['name' => 'NL:AMS:EQ:AM11'],
        ['name' => 'NL:AMS:DR:AMS3'],
        ['name' => 'NL:AMS:DR:AMS17'],
        ['name' => 'USA:ASH:EQ:DC10'],
    ],
];

This approach would centralize the location management and make it easier to add, remove, or modify locations in the future.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 358af8a and 5cf2337.

📒 Files selected for processing (1)

• src/controllers/MobileController.php (1 hunks)