HP-2081: fixed Stock Part index Codecept test

[VadymHrechukha]

https://git.hiqdev.com/advancedhosters/hipanel.advancedhosters.com/-/jobs/385493

Summary by CodeRabbit

• New Features
  • Enhanced advanced search functionality with updated input parameters for improved user experience.
  • Added new search parameters for more precise filtering options.

[coderabbitai]

Walkthrough

The changes involve modifications to the Input::asAdvancedSearch method in the PartIndexCest.php file. The parameters for 'First move' and 'Last move' have been updated to 'First move description' and 'Last move description'. Additionally, two new parameters, 'First move source regexp' and 'First move destination regexp', have been introduced, altering the inputs used in the advanced search functionality.

Changes

Files	Change Summary
tests/acceptance/manager/part/PartIndexCest.php	Updated parameters in Input::asAdvancedSearch method; replaced and added parameters for advanced search.

Possibly related PRs

• HP-2029: change replace UI #172: The changes in PartIndexCest.php regarding the Input::asAdvancedSearch method may relate to the UI modifications in the replace functionality, as both involve alterations to the handling of part-related data.
• HP-2117: Allow '-' symbol in part serialno on /stock/part/replace page #177: The modification of the serial attribute validation in Part.php could be relevant as it may affect how parts are searched or displayed in the advanced search functionality, particularly if serial numbers are part of the search criteria.

Poem

🐰 In the fields where parts do play,
New descriptions brighten the day.
With regex dreams and searches wide,
Hop along, let changes glide!
Advanced search, a joyful quest,
In code we trust, we do our best! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

tests/acceptance/manager/part/PartIndexCest.php (1)

55-58: LGTM! Consider adding a comment for clarity.

The changes to the advanced search parameters look good and align with the PR objective. They refine the search functionality by:

1. Specifying 'description' for first and last moves.
2. Adding regexp capabilities for first move source and destination.

These updates likely reflect changes in the actual application's search functionality, improving the test coverage.

Consider adding a brief comment above these lines to explain the purpose of these specific search parameters, especially the new regexp ones. This would enhance code readability and maintainability. For example:

// Advanced search parameters for move tracking and pattern matching
Input::asAdvancedSearch($I, 'First move description'),
Input::asAdvancedSearch($I, 'Last move description'),
Input::asAdvancedSearch($I, 'First move source regexp'),
Input::asAdvancedSearch($I, 'First move destination regexp'),

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f4ee783 and d6a19ed.

📒 Files selected for processing (1)

• tests/acceptance/manager/part/PartIndexCest.php (1 hunks)