HP-2335 created role:bill.staff-manager and role:staff-manager

Author: VadymHrechukha

src/files/items.php

@@ -141,6 +141,14 @@
             'server.assign-hub',
         ],
     ],
+    'role:bill.staff-manager' => [
+        'type' => 1,
+        'children' => [
+            'role:bill.manager',
+            'bill.charges.read',
+            'bill.see-server-charges',
+        ],
+    ],
     'role:server.master' => [
         'type' => 1,
         'description' => 'The role is generally assigned to staff who have exceptionally high permissions on servers management',
@@ -884,6 +892,13 @@
             'role:hub.staff-admin',
         ],
     ],
+    'role:staff-manager' => [
+        'type' => 1,
+        'children' => [
+            'role:bill.staff-manager',
+            'see-no-mans',
+        ],
+    ],
     'role:accounter' => [
         'type' => 1,
         'description' => 'The role is generally assigned to staff who are in charge of accounting',
@@ -1142,6 +1157,7 @@
         'description' => 'The role is for testing only',
         'children' => [
             'role:staff-admin',
+            'role:staff-manager',
             'role:manager',
             'role:document.master',
             'role:finance.master',
@@ -1606,6 +1622,22 @@
         'type' => 2,
         'description' => 'Prohibits assign hub to server',
     ],
+    'bill.charges.read' => [
+        'type' => 2,
+        'description' => 'Allows charges.read operation on the bill',
+    ],
+    'deny:bill.charges.read' => [
+        'type' => 2,
+        'description' => 'Prohibits charges.read operation on the bill',
+    ],
+    'bill.see-server-charges' => [
+        'type' => 2,
+        'description' => 'Allows to see server charges (detailed bill info)',
+    ],
+    'deny:bill.see-server-charges' => [
+        'type' => 2,
+        'description' => 'Denies to see server charges (detailed bill info)',
+    ],
     'hub.read' => [
         'type' => 2,
         'description' => 'Allows reading of the hub',
@@ -2704,6 +2736,14 @@
         'type' => 2,
         'description' => 'Prohibits admining',
     ],
+    'see-no-mans' => [
+        'type' => 2,
+        'description' => 'Allows see-no-mans operation',
+    ],
+    'deny:see-no-mans' => [
+        'type' => 2,
+        'description' => 'Prohibits see-no-mans operation',
+    ],
     'manage' => [
         'type' => 2,
         'description' => 'Allows manageing',
@@ -2768,14 +2808,6 @@
         'type' => 2,
         'description' => 'Prohibits owning',
     ],
-    'see-no-mans' => [
-        'type' => 2,
-        'description' => 'Allows see-no-mans operation',
-    ],
-    'deny:see-no-mans' => [
-        'type' => 2,
-        'description' => 'Prohibits see-no-mans operation',
-    ],
     'part.sell' => [
         'type' => 2,
         'description' => 'Allows selling of the part',
@@ -3056,22 +3088,6 @@
         'type' => 2,
         'description' => 'Prohibits view.not-used operation on the ref',
     ],
-    'bill.charges.read' => [
-        'type' => 2,
-        'description' => 'Allows charges.read operation on the bill',
-    ],
-    'deny:bill.charges.read' => [
-        'type' => 2,
-        'description' => 'Prohibits charges.read operation on the bill',
-    ],
-    'bill.see-server-charges' => [
-        'type' => 2,
-        'description' => 'Allows to see server charges (detailed bill info)',
-    ],
-    'deny:bill.see-server-charges' => [
-        'type' => 2,
-        'description' => 'Denies to see server charges (detailed bill info)',
-    ],
     'client.set-description' => [
         'type' => 2,
         'description' => 'Allows set-description operation on the client',

src/files/source/tree.php

@@ -62,6 +62,11 @@
         'server.update',
         'server.assign-hub',
     ],
+    'role:bill.staff-manager' => [
+        'role:bill.manager',
+        'bill.charges.read',
+        'bill.see-server-charges',
+    ],
     'role:server.master' => [
         'role:server.staff-admin', 'role:server.manager',
     ],
@@ -384,6 +389,10 @@
         'role:server.staff-admin',
         'role:hub.staff-admin',
     ],
+    'role:staff-manager' => [
+        'role:bill.staff-manager',
+        'see-no-mans',
+    ],
     'role:accounter' => [
         'role:manager',
         'role:hub.manager',
@@ -512,6 +521,7 @@
     ],
     'role:almighty' => [
         'role:staff-admin',
+        'role:staff-manager',
         'role:manager',
         'role:document.master',
         'role:finance.master',

tests/unit/CheckAccessTrait.php

@@ -528,7 +528,9 @@ public function testAlmighty()
             'purse.set-credit','server.read-wizzard','server.read-legend','server.read-financial-info', 'server.read-system-info',
             'server.read-billing','server.assign-hub', 'plan.set-note',
             'client.read-financial-info', 'client.read-requisite', 'client.read-referral', 'client.read-deleted', 'client.read-ip',
-            'part.read-administrative', 'ticket.read-templates', 'ticket.read-statistics', 'ticket.set-private', 'ticket.set-recipient', 'ticket.set-time'
+            'part.read-administrative', 'ticket.read-templates', 'ticket.read-statistics', 'ticket.set-private', 'ticket.set-recipient', 'ticket.set-time',
+
+            'see-no-mans', 'bill.charges.read', 'bill.see-server-charges',
         ]);
     }