HP-1751 complete BillingRegistryInterface

Author: VadymHrechukha

src/product/BillingRegistry.php

@@ -7,7 +7,6 @@
 use hiqdev\php\billing\product\invoice\InvalidRepresentationException;
 use hiqdev\php\billing\product\invoice\RepresentationInterface;
 use hiqdev\php\billing\product\price\PriceTypeDefinition;
-use hiqdev\php\billing\product\price\PriceTypeDefinitionInterface;
 use hiqdev\php\billing\product\quantity\QuantityFormatterInterface;
 use hiqdev\php\billing\product\quantity\QuantityFormatterNotFoundException;
 use hiqdev\php\billing\product\quantity\FractionQuantityData;
@@ -32,10 +31,6 @@ public function addTariffType(TariffTypeDefinitionInterface $tariffTypeDefinitio
         $this->tariffTypeDefinitions[] = $tariffTypeDefinition;
     }
 
-    /**
-     * @return \Generator
-     * @psalm-return \Generator<PriceTypeDefinitionInterface>
-     */
     public function priceTypes(): \Generator
     {
         foreach ($this->tariffTypeDefinitions as $tariffTypeDefinition) {
@@ -45,10 +40,6 @@ public function priceTypes(): \Generator
         }
     }
 
-    /**
-     * @param string $representationClass
-     * @return RepresentationInterface[]
-     */
     public function getRepresentationsByType(string $representationClass): array
     {
         if (!class_exists($representationClass)) {
@@ -93,13 +84,6 @@ private function convertStringTypeToType(string $type): TypeInterface
         return Type::anyId($type);
     }
 
-    /**
-     * @param string $type - full type like 'overuse,lb_capacity_unit'
-     * @param string $behaviorClassWrapper
-     * @return BehaviorInterface
-     * @throws BehaviorNotFoundException
-     * @throws InvalidBehaviorException
-     */
     public function getBehavior(string $type, string $behaviorClassWrapper): BehaviorInterface
     {
         if (!class_exists($behaviorClassWrapper)) {
@@ -176,10 +160,6 @@ public function getAggregate(string $type): AggregateInterface
         throw new AggregateNotFoundException('Aggregate was not found');
     }
 
-    /**
-     * @return \Generator
-     * @psalm-return \Generator<TariffTypeDefinitionInterface>
-     */
     public function getTariffTypeDefinitions(): \Generator
     {
         foreach ($this->tariffTypeDefinitions as $tariffTypeDefinition) {

src/product/BillingRegistryInterface.php

@@ -3,13 +3,54 @@
 namespace hiqdev\php\billing\product;
 
 use Generator;
-use hiqdev\php\billing\product\price\PriceTypeDefinition;
+use hiqdev\php\billing\product\behavior\BehaviorInterface;
+use hiqdev\php\billing\product\behavior\BehaviorNotFoundException;
+use hiqdev\php\billing\product\behavior\InvalidBehaviorException;
+use hiqdev\php\billing\product\invoice\RepresentationInterface;
+use hiqdev\php\billing\product\price\PriceTypeDefinitionInterface;
+use hiqdev\php\billing\product\quantity\FractionQuantityData;
+use hiqdev\php\billing\product\quantity\QuantityFormatterInterface;
 use hiqdev\php\billing\product\trait\HasLockInterface;
 
 interface BillingRegistryInterface extends HasLockInterface
 {
     /**
-     * @return Generator<PriceTypeDefinition>
+     * @return Generator
+     * @psalm-return Generator<PriceTypeDefinitionInterface>
      */
     public function priceTypes(): Generator;
+
+    public function addTariffType(TariffTypeDefinitionInterface $tariffTypeDefinition): void;
+
+    /**
+     * @param string $representationClass
+     * @return RepresentationInterface[]
+     */
+    public function getRepresentationsByType(string $representationClass): array;
+
+    public function createQuantityFormatter(string $type, FractionQuantityData $data): QuantityFormatterInterface;
+
+    /**
+     * @param string $type - full type like 'overuse,lb_capacity_unit'
+     * @param string $behaviorClassWrapper
+     * @return BehaviorInterface
+     * @throws BehaviorNotFoundException
+     * @throws InvalidBehaviorException
+     */
+    public function getBehavior(string $type, string $behaviorClassWrapper): BehaviorInterface;
+
+    /**
+     * @param string $behaviorClassWrapper
+     * @return Generator
+     * @psalm-return Generator<BehaviorInterface>
+     */
+    public function getBehaviors(string $behaviorClassWrapper): Generator;
+
+    public function getAggregate(string $type): AggregateInterface;
+
+    /**
+     * @return Generator
+     * @psalm-return Generator<TariffTypeDefinitionInterface>
+     */
+    public function getTariffTypeDefinitions(): Generator;
 }