propagated better error messages for undefnied term to tests

Author: Chronarak

hkmc2/shared/src/main/scala/hkmc2/utils/Scope.scala

@@ -99,7 +99,6 @@ class Scope
       raise(ErrorReport(msg"No definition found in scope for '${l.nme}'" -> loc :: Nil,
         extraInfo = Some(l -> l.getClass),
         source = Diagnostic.Source.Compilation))
-        source = Diagnostic.Source.Compilation))
       l.nme
 
   def allocateName(l: Local, prefix: Str = ""): Str =

hkmc2/shared/src/test/mlscript/backlog/Lifter.mls

@@ -158,7 +158,7 @@ fun foo(x, y) =
   fun foo = M.foo()
   foo
 //│ ═══[WARNING] Modules are not yet lifted.
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: member:M (class hkmc2.semantics.BlockMemberSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'M'
 //│ ║  l.154: 	  module M with
 //│ ╙──       	         ^
 
@@ -186,7 +186,7 @@ fun foo(x) =
   class Bar extends Foo
   (new Bar).self2
 foo(2)
-//│ ═══[COMPILATION ERROR] No definition found in scope for: Foo$ (class hkmc2.semantics.VarSymbol)
+//│ ═══[COMPILATION ERROR] No definition found in scope for 'Foo$'
 //│ ═══[RUNTIME ERROR] TypeError: Foo1 is not a function
 
 // `h` is lifted out, but then cannot access the BlockMemberSymbol M.
@@ -198,6 +198,6 @@ fun f =
       h
   M.g
 //│ ═══[WARNING] Modules are not yet lifted.
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: member:M (class hkmc2.semantics.BlockMemberSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'M'
 //│ ║  l.195: 	  module M with
 //│ ╙──       	         ^

hkmc2/shared/src/test/mlscript/backlog/ToTriage.mls

@@ -164,7 +164,7 @@ f of
 fun p: Int
 
 p
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: member:p (class hkmc2.semantics.BlockMemberSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'p'
 //│ ║  l.164: 	fun p: Int
 //│ ╙──       	    ^^^^^^
 //│ ═══[RUNTIME ERROR] ReferenceError: p is not defined
@@ -177,14 +177,14 @@ fun (++) test: (Int, Int) -> Int
 //│   test -> RefElem(member:test)
 
 test(1, 2)
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: member:test (class hkmc2.semantics.BlockMemberSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'test'
 //│ ║  l.174: 	fun (++) test: (Int, Int) -> Int
 //│ ╙──       	    ^^^^^^^^^^^^^^^^^^^^^
 //│ ═══[RUNTIME ERROR] ReferenceError: test is not defined
 
 :sjs
 1 ++ 1
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: member:test (class hkmc2.semantics.BlockMemberSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'test'
 //│ ║  l.174: 	fun (++) test: (Int, Int) -> Int
 //│ ╙──       	    ^^^^^^^^^^^^^^^^^^^^^
 //│ JS (unsanitized):
@@ -276,7 +276,7 @@ let xs = new Oopsie
 //│ ╔══[ERROR] Name not found: Oopsie
 //│ ║  l.275: 	let xs = new Oopsie
 //│ ╙──       	             ^^^^^^
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: xs (class hkmc2.semantics.VarSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'xs'
 //│ ║  l.275: 	let xs = new Oopsie
 //│ ╙──       	    ^^
 //│ ═══[RUNTIME ERROR] ReferenceError: xs is not defined

hkmc2/shared/src/test/mlscript/basics/Records.mls

@@ -78,7 +78,7 @@ let rcd =
 //│ ╔══[ERROR] Name not found: bar
 //│ ║  l.73: 	  bar =
 //│ ╙──      	  ^^^
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: rcd (class hkmc2.semantics.VarSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'rcd'
 //│ ║  l.71: 	let rcd =
 //│ ╙──      	    ^^^
 //│ rcd = {foo: 1, bar: "..."}

hkmc2/shared/src/test/mlscript/codegen/PartialApps.mls

@@ -90,15 +90,15 @@ _ + 1 >> _ * 2 <| 123
 :todo
 let j = _.x
 //│ ═══[ERROR] Illegal position for '_' placeholder.
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: j (class hkmc2.semantics.VarSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'j'
 //│ ║  l.91: 	let j = _.x
 //│ ╙──      	    ^
 //│ ═══[RUNTIME ERROR] ReferenceError: j is not defined
 
 :todo
 let j = _.x(123)
 //│ ═══[ERROR] Illegal position for '_' placeholder.
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: j (class hkmc2.semantics.VarSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'j'
 //│ ║  l.99: 	let j = _.x(123)
 //│ ╙──      	    ^
 //│ ═══[RUNTIME ERROR] ReferenceError: j is not defined

hkmc2/shared/src/test/mlscript/ctx/MissingDefinitions.mls

@@ -12,7 +12,7 @@ g(5)
 :ge
 :re
 f(1)
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: member:f (class hkmc2.semantics.BlockMemberSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'f'
 //│ ║  l.3: 	fun f: Any -> Any
 //│ ╙──     	    ^^^^^^^^^^^^^
 //│ ═══[RUNTIME ERROR] ReferenceError: f is not defined
@@ -25,6 +25,6 @@ fun g(x) = f(x)
 :js
 :ge
 fun g(x) = f(x)
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: member:f (class hkmc2.semantics.BlockMemberSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'f'
 //│ ║  l.3: 	fun f: Any -> Any
 //│ ╙──     	    ^^^^^^^^^^^^^

hkmc2/shared/src/test/mlscript/ctx/TrickyResolution.mls

@@ -23,7 +23,7 @@ use Bar[Str] = new Bar
 // * and thus picks the Bar[Int] instance
 :fixme
 foo
-//│ ╔══[COMPILATION ERROR] No definition found in scope for: member:foo (class hkmc2.semantics.BlockMemberSymbol)
+//│ ╔══[COMPILATION ERROR] No definition found in scope for 'foo'
 //│ ║  l.13: 	fun foo[A](using f: Foo[A], b: Bar[A]): A
 //│ ╙──      	    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 //│ ═══[RUNTIME ERROR] ReferenceError: foo is not defined