Type Selection #219
Closed
Type Selection #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not included in this PR:
|
LPTK
reviewed
Jan 21, 2025
| @@ -28,7 +28,7 @@ abstract class Test[C] { | |||
| // * Represents what happens in "... ${input} ..." when a binding of C is in scope | |||
| fun unquote: (input: Code['a, C | 'c]) -> Code[Int, 'c] | |||
| fun getVar: Code[Int, C] | |||
| fun test0 = this.unquote of IntLit(1) | |||
| fun test0 = this.unquote of (IntLit(1) : Code['ia, 'ic]) // ? why ascription works here | |||
| //│ class C(x: Int, y: Str) | ||
|
|
||
|
|
||
| :d |
|
Thanks for the great work! However, as you know, we've moved to a new version of the compiler, which will have a brand new type checker implementation. So while your PR is useful for future reference when we reimplement similar features in the new compiler (I will add a tag to that effect), it's probably not worth fixing the merge conflicts with the old type checker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Foo[type A extends L restricts U]x.Aasoperator?