Llir improvement #292
Llir improvement #292
Conversation
waterlens
commented
Mar 17, 2025
•
waterlens
commented
- Clean on-going optimizer code out
- Figure out why the merge break the class lifter tests
# Conflicts: # .github/workflows/nix.yml # hkmc2/shared/src/main/scala/hkmc2/codegen/Printer.scala # hkmc2DiffTests/src/test/scala/hkmc2/DiffTestRunner.scala
# Conflicts: # hkmc2/shared/src/main/scala/hkmc2/codegen/llir/Builder.scala
|
I think this PR is now ready to be merged. @LPTK |
| output(cpp.toDocument.toString) | ||
| val rPath = os.Path(rootPath) | ||
| val auxPath = | ||
| if rPath.last == "mlscript" then |
There was a problem hiding this comment.
This logic is incorrect: you cannot assume that the folder containing this github clone is named "mlscript".
There was a problem hiding this comment.
Now, I'll switch to check the relative path. This won't cause issues unless we move the subproject out of the hkmc2/shared directory. If that happens, many things will likely break too, and we can apply a new fix in a batch together. How do you think about this?
There was a problem hiding this comment.
It was still wrong (what if the MLscript project is cloned in a folder named shared?), but I've fixed it now.
|
Also, we should probably comment out the |
|
Don't forget to delete the branch (it looks like I can't do it myself for some reason). |
Sure. |
|
Usually, I have the option of deleting merged branches even when they're from other forks. There's probably an option somewhere. |
Co-authored-by: Lionel Parreaux <lionel.parreaux@gmail.com>
