improvement: add confirmation before deleting item #787
Conversation
lexafaxine
force-pushed
the
delete-bookmark-confirmation
branch
from
a50cac9 to
3b39327
Compare
| <ActionButton | ||
| loading={pendingDeletion} | ||
| loading={isPendingDelete} | ||
| className="size-14 rounded-full bg-background" | ||
| variant="none" | ||
| onClick={() => { | ||
| deleteBookmark({ bookmarkId: bookmark.id }); | ||
| }} | ||
| onClick={() => setDeleteBookmarkDialogOpen(true)} | ||
| > |
There was a problem hiding this comment.
Given that this button no longer itself takes an action, we should switch it to just a normal button instead of ActionButton. That way, you also won't need to propagate the pending state back to this component.
There was a problem hiding this comment.
| <DeleteBookmarkConfirmationDialog | ||
| bookmark={bookmark} | ||
| open={deleteBookmarkDialogOpen} | ||
| setOpen={setDeleteBookmarkDialogOpen} | ||
| /> |
There was a problem hiding this comment.
I think this probably should be moved out of the dropdown menu. Maybe move it beside the other modals on line 108?
There was a problem hiding this comment.
| open={open} | ||
| setOpen={setOpen} | ||
| title={`Delete ${bookmark.title ?? "Bookmark"}?`} | ||
| description={`Are you sure you want to delete this bookmark?`} |
There was a problem hiding this comment.
Can you add this to the translation files in apps/web/lib/i18n/locales/en.json? So that people can also get a chance to translate it?
There was a problem hiding this comment.
Sure, added it in add delete bookmark confirmation dialog
lexafaxine
force-pushed
the
delete-bookmark-confirmation
branch
from
52924c6 to
571c730
Compare
lexafaxine
force-pushed
the
delete-bookmark-confirmation
branch
from
571c730 to
5460f44
Compare
|
Thank you and congrats on the first contribution in Hoarder! |
PR for #776
For mobile,
added an alert when deleting bookmark
For web,
added an confirmation dialog when deleting bookmark
Proof:
https://drive.google.com/drive/folders/1067NHRKKIoip3vZRfgaJnbxBj1XHf5oc?usp=sharing