-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-487: add defining mutations page #498
Merged
JonasKellerer
merged 2 commits into
414-defining-mutations
from
487-create-defining-mutations-page-and-sub-pages
Feb 20, 2025
Merged
feat-487: add defining mutations page #498
JonasKellerer
merged 2 commits into
414-defining-mutations
from
487-create-defining-mutations-page-and-sub-pages
Feb 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bb0c984
to
09431c9
Compare
AdvancedCodingMonkey
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for porting this. Left some small comments and questions.
web/src/components/DefiningMutations/DefiningMutationByCluster/DefiningMutationsPage.tsx
Outdated
Show resolved
Hide resolved
web/src/components/DefiningMutations/DefiningMutationByCluster/DefiningMutationsPage.tsx
Outdated
Show resolved
Hide resolved
web/src/components/DefiningMutations/DefiningMutationByCluster/DefiningMutationsPage.tsx
Outdated
Show resolved
Hide resolved
web/src/components/DefiningMutations/DefiningMutationByCluster/DefiningMutationsPage.tsx
Outdated
Show resolved
Hide resolved
web/src/components/DefiningMutations/DefiningMutationByCluster/SelectClusterDropdown.tsx
Show resolved
Hide resolved
web/src/components/DefiningMutations/DefiningMutationByCluster/SelectReferenceDropdown.tsx
Outdated
Show resolved
Hide resolved
web/src/components/DefiningMutations/DefiningMutationByCluster/DefiningMutationsTable.tsx
Show resolved
Hide resolved
6c2cbc8
to
3f4480d
Compare
3f4480d
to
77cc19c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #487
This PR uses the groundwork of #380 and adapts to the new code style.
It adds the defining mutation page. This page shows a searchable table of all available defining mutations.
These mutations have to be provided in the folder
public/data/definingMutations
. A complete list of all defining mutations must be placed indefiningMutationClusters.json
. The defined mutations then must be placed next to this, each in a separate file.For each defining mutation there is then a page, displaying the general info and the defining mutations.
Leftover tasks (which will need to be adressed in other issues/PRs)