Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-487: add defining mutations page #498

Conversation

JonasKellerer
Copy link
Collaborator

Resolves #487

This PR uses the groundwork of #380 and adapts to the new code style.

It adds the defining mutation page. This page shows a searchable table of all available defining mutations.

grafik

These mutations have to be provided in the folder public/data/definingMutations. A complete list of all defining mutations must be placed in definingMutationClusters.json. The defined mutations then must be placed next to this, each in a separate file.

For each defining mutation there is then a page, displaying the general info and the defining mutations.

grafik

Leftover tasks (which will need to be adressed in other issues/PRs)

  • improve design of page
  • improve design of table
  • pagination for defining mutations table
  • search for defining mutations table
  • sort defining mutations table
  • add meaningfull info texts, both to index and defining mutation pages

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
covariants ✅ Ready (Inspect) Visit Preview Feb 12, 2025 10:50am

@AdvancedCodingMonkey AdvancedCodingMonkey changed the base branch from master to 414-defining-mutations February 13, 2025 11:54
@AdvancedCodingMonkey AdvancedCodingMonkey force-pushed the 487-create-defining-mutations-page-and-sub-pages branch from bb0c984 to 09431c9 Compare February 13, 2025 12:06
Copy link
Collaborator

@AdvancedCodingMonkey AdvancedCodingMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for porting this. Left some small comments and questions.

@JonasKellerer JonasKellerer force-pushed the 487-create-defining-mutations-page-and-sub-pages branch from 3f4480d to 77cc19c Compare February 20, 2025 12:55
@JonasKellerer JonasKellerer merged commit bf1406b into 414-defining-mutations Feb 20, 2025
2 checks passed
@JonasKellerer JonasKellerer deleted the 487-create-defining-mutations-page-and-sub-pages branch February 20, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create defining mutations page and sub-pages
2 participants