Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for qingping pro air quality custom integration #5769

Closed
wants to merge 6 commits into from

Conversation

mash2k3
Copy link
Contributor

@mash2k3 mash2k3 commented Aug 15, 2024

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @mash2k3 👋

I could not find the public repository providing this custom integration. Can you please point me to it?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft August 25, 2024 18:28
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mash2k3
Copy link
Contributor Author

mash2k3 commented Aug 26, 2024 via email

@mash2k3 mash2k3 marked this pull request as ready for review August 28, 2024 15:07
@home-assistant home-assistant bot requested a review from frenck August 28, 2024 15:07
@mash2k3
Copy link
Contributor Author

mash2k3 commented Aug 28, 2024

Copy link
Contributor Author

@mash2k3 mash2k3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mash2k3 mash2k3 closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants