Skip to content

Commit 914dc66

Browse files
maint: Add warning to NOTES.txt when no resouce limits are set (#298)
## Which problem is this PR solving? It is recommended to set resource limits when running the Network Agent. Related to: - honeycombio/honeycomb-network-agent#193 ## Short description of the changes - Adds a waning to NOTES.txt when no resources are provided ## How to verify that this has the expected result A warning is printed when no resources are provided when installing the chart.
1 parent b1c5337 commit 914dc66

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

charts/network-agent/templates/NOTES.txt

+4
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,7 @@ You should see data flowing within a few minutes at https://ui.honeycomb.io.
2020
{{- if and (.Values.honeycomb.existingSecret) (not .Values.honeycomb.existingSecretKey) }}
2121
{{ fail "[ERROR] You must set a valid value for 'honeycomb.existingSecretKey' when using 'honeycomb.existingSecret' to provide your Honeycomb API key." }}
2222
{{- end }}
23+
24+
{{- if not .Values.resources }}
25+
[WARNING] No resource limits or requests were set. Consider setter resource requests and limits for the Network Agent via the `resources` field.
26+
{{ end }}

0 commit comments

Comments
 (0)