You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
maint: Add warning to NOTES.txt when no resouce limits are set (#298)
## Which problem is this PR solving?
It is recommended to set resource limits when running the Network Agent.
Related to:
- honeycombio/honeycomb-network-agent#193
## Short description of the changes
- Adds a waning to NOTES.txt when no resources are provided
## How to verify that this has the expected result
A warning is printed when no resources are provided when installing the
chart.
Copy file name to clipboardexpand all lines: charts/network-agent/templates/NOTES.txt
+4
Original file line number
Diff line number
Diff line change
@@ -20,3 +20,7 @@ You should see data flowing within a few minutes at https://ui.honeycomb.io.
20
20
{{- if and (.Values.honeycomb.existingSecret) (not .Values.honeycomb.existingSecretKey) }}
21
21
{{ fail "[ERROR] You must set a valid value for 'honeycomb.existingSecretKey' when using 'honeycomb.existingSecret' to provide your Honeycomb API key." }}
22
22
{{- end }}
23
+
24
+
{{- if not .Values.resources }}
25
+
[WARNING] No resource limits or requests were set. Consider setter resource requests and limits for the Network Agent via the `resources` field.
0 commit comments