Skip to content

Commit

Permalink
fix: ingest munged parent span IDs (#186)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?

- follow-up to #184 

## Short description of the changes

- Parse parent span IDs like we do span IDs to deal with base64
shenanigans
  • Loading branch information
robbkidd authored Mar 9, 2023
1 parent 00658f6 commit 7919226
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion otlp/traces.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func TranslateTraceRequest(request *collectorTrace.ExportTraceServiceRequest, ri
"meta.signal_type": "trace",
}
if span.ParentSpanId != nil {
eventAttrs["trace.parent_id"] = hex.EncodeToString(span.ParentSpanId)
eventAttrs["trace.parent_id"] = bytesToSpanID(span.ParentSpanId)
}
if isError {
eventAttrs["error"] = true
Expand Down

0 comments on commit 7919226

Please sign in to comment.