Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use Github Actions to build and publish docker images to GHCR #1494

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

irvingpop
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • This PR adds a Github Actions native workflow, which builds and publishes a Docker container exactly the same way as build-docker.sh and CircleCI, but with a greatly simplified configuration.

I tested this out in a forked repo, with the results here: https://github.com/irvingpop/refinery/pkgs/container/refinery

CleanShot 2025-02-24 at 16 21 16

Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
@irvingpop irvingpop requested a review from a team as a code owner February 25, 2025 00:21
@irvingpop irvingpop changed the title Use Github Actions to build and publish docker images to GHCR feat: Use Github Actions to build and publish docker images to GHCR Feb 25, 2025
@TylerHelmuth TylerHelmuth added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Feb 25, 2025

- name: Build and push Docker images using ko
run: >
ko build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamieDanielson had an idea that instead of building a new image, can this action be dependent on the cirlceci job completing and then pull the image and re-push it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we'd want/need this to happen after a successful build and publish. So it looks like you can change the trigger to be on release publish

on:
  release:
    types: [published]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh neat! updated.

Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
@verythorough
Copy link

I'm sure y'all have already thought of this, but I wanted to note that once we have this option, we'll probably want to add it to the docs anywhere we mention using Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants