Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add OpAMPRecordUsage option #1500

Merged
merged 3 commits into from
Mar 6, 2025
Merged

feat: add OpAMPRecordUsage option #1500

merged 3 commits into from
Mar 6, 2025
+225 −40

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Mar 6, 2025

Which problem is this PR solving?

To make sure all traffic is only counted once, Refinery will only report usage if it is receiving traffic from client directly.

Short description of the changes

  • add OpAMPRecordUsage config option and default to true
  • fix a metrics name bug
  • add unit test
  • generate config docs

@VinozzZ VinozzZ self-assigned this Mar 6, 2025
@VinozzZ VinozzZ requested a review from a team as a code owner March 6, 2025 18:23
@VinozzZ VinozzZ merged commit ea8eed9 into codeboten/opamp Mar 6, 2025
4 checks passed
@VinozzZ VinozzZ deleted the yingrong/add_switch_for_recording_usage branch March 6, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees

@VinozzZ VinozzZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VinozzZ @TylerHelmuth