Skip to content

Commit 61d19b1

Browse files
committed
Fix the turbo-stream checking
1 parent b79a073 commit 61d19b1

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

src/Http/Middleware/TurboMiddleware.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
use Illuminate\Support\Str;
1010
use Illuminate\Validation\ValidationException;
1111
use Tonysm\TurboLaravel\NamesResolver;
12+
use Tonysm\TurboLaravel\Turbo;
1213
use Tonysm\TurboLaravel\TurboFacade;
1314

1415
class TurboMiddleware
@@ -72,7 +73,7 @@ private function turboResponse($response, Request $request)
7273
*/
7374
private function turboVisit($request)
7475
{
75-
return Str::contains($request->header('Accept', ''), 'turbo-stream');
76+
return Str::contains($request->header('Accept', ''), Turbo::TURBO_STREAM_FORMAT);
7677
}
7778

7879
/**

src/Models/Broadcasts.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
use Tonysm\TurboLaravel\Jobs\BroadcastModelCreated;
77
use Tonysm\TurboLaravel\Jobs\BroadcastModelUpdated;
88
use Tonysm\TurboLaravel\LaravelBroadcaster;
9-
use Tonysm\TurboLaravel\NamesResolver;
109
use Tonysm\TurboLaravel\TurboFacade;
1110

1211
/**

tests/Http/Middleware/TurboMiddlewareTest.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
use Tonysm\TurboLaravel\Http\Middleware\TurboMiddleware;
1010
use Tonysm\TurboLaravel\Tests\TestCase;
1111
use Tonysm\TurboLaravel\Tests\TestModel;
12+
use Tonysm\TurboLaravel\Turbo;
1213
use Tonysm\TurboLaravel\TurboFacade;
1314

1415
class TurboMiddlewareTest extends TestCase
@@ -36,7 +37,7 @@ public function handles_redirect_responses()
3637
{
3738
$request = Request::create('/source');
3839
$request->headers->add([
39-
'Accept' => 'text/html; turbo-stream, text/html, application/xhtml+xml',
40+
'Accept' => sprintf('%s, text/html, application/xhtml+xml', Turbo::TURBO_STREAM_FORMAT),
4041
]);
4142
$response = new RedirectResponse('/destination');
4243
$next = function () use ($response) {
@@ -82,7 +83,7 @@ public function respects_the_redirects_to_property_of_the_validation_failed_exce
8283
$request = Request::create('/test-models', 'POST');
8384

8485
$request->headers->add([
85-
'Accept' => 'text/html; turbo-stream, text/html, application/xhtml+xml',
86+
'Accept' => sprintf('%s, text/html, application/xhtml+xml', Turbo::TURBO_STREAM_FORMAT),
8687
]);
8788

8889
$next = function () {
@@ -115,7 +116,7 @@ public function redirects_back_to_resource_create_routes_on_failed_validation_fo
115116
})->name('test-models.store')->middleware(TurboMiddleware::class);
116117

117118
$response = $this->from('/source')->post(route('test-models.store'), [], [
118-
'Accept' => 'text/html; turbo-stream, text/html, application/xhtml+xml',
119+
'Accept' => sprintf('%s, text/html, application/xhtml+xml', Turbo::TURBO_STREAM_FORMAT),
119120
]);
120121

121122
$response->assertRedirect(route('test-models.create'));
@@ -136,7 +137,7 @@ public function redirects_back_to_resource_edit_routes_on_failed_validation_foll
136137
$testModel = TestModel::create(['name' => 'Dummy model']);
137138

138139
$response = $this->from('/source')->put(route('test-models.update', $testModel), [], [
139-
'Accept' => 'text/html; turbo-stream, text/html, application/xhtml+xml',
140+
'Accept' => sprintf('%s, text/html, application/xhtml+xml', Turbo::TURBO_STREAM_FORMAT),
140141
]);
141142

142143
$response->assertRedirect(route('test-models.edit', $testModel));
@@ -153,7 +154,7 @@ public function lets_it_crash_when_redirect_route_does_not_exist()
153154
$testModel = TestModel::create(['name' => 'Dummy model']);
154155

155156
$response = $this->from('/source')->put(route('test-models.update', $testModel), [], [
156-
'Accept' => 'text/html; turbo-stream, text/html, application/xhtml+xml',
157+
'Accept' => sprintf('%s, text/html, application/xhtml+xml', Turbo::TURBO_STREAM_FORMAT),
157158
]);
158159

159160
$response->assertRedirect('/source');

0 commit comments

Comments
 (0)