Skip to content

Commit 86f2f42

Browse files
committed
Disable devel checks for PRRTE/PMIx
The PRRTE and PMIx modules set `-Werror`, which has repeatedly led to builds of Open MPI breaking due to mere warnings that have otherwise no impact on correctness or performance. Warnings are tricky to catch since different compilers detect these minor issues with different precision. We do not control these code base and are merely consumers, so we should not accept third-party projects inhibiting our ability to build code inside a git repository. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
1 parent 9656f59 commit 86f2f42

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

config/ompi_setup_prrte.m4

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,8 @@ AC_DEFUN([_OMPI_SETUP_PRRTE_INTERNAL], [
164164
165165
internal_prrte_CPPFLAGS=
166166
internal_prrte_args="--with-proxy-version-string=$OPAL_VERSION --with-proxy-package-name=\"Open MPI\" --with-proxy-bugreport=\"https://www.open-mpi.org/community/help/\""
167+
# PRRTE sets -Werror on devel builds so avoid buid breaks caused by 3rd-party codes
168+
internal_prrte_args="$internal_prrte_args --disable-devel-check"
167169
168170
# Set --enable-prte-prefix-by-default to the deprecated options,
169171
# if they were specified. Otherwise, set it to enabled if the

config/opal_config_pmix.m4

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ AC_DEFUN([OPAL_CONFIG_PMIX], [
7878
# desired.
7979
8080
internal_pmix_args="--without-tests-examples --enable-pmix-binaries --disable-pmix-backward-compatibility --disable-visibility"
81+
# Open PMIx sets -Werror on devel builds so avoid buid breaks caused by 3rd-party codes
82+
internal_pmix_args="$internal_pmix_args --disable-devel-check"
8183
internal_pmix_wrapper_libs=
8284
internal_pmix_CPPFLAGS=
8385

0 commit comments

Comments
 (0)