Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CxxWrap.jl v0.16 #54

Closed
sloede opened this issue Jun 11, 2024 · 3 comments · Fixed by #55
Closed

Update to CxxWrap.jl v0.16 #54

sloede opened this issue Jun 11, 2024 · 3 comments · Fixed by #55

Comments

@sloede
Copy link
Member

sloede commented Jun 11, 2024

The new version of CxxWrap.jl is breaking (see #53) because it requires the underlying libcxxwrap-julia version to be updated (see https://github.com/JuliaInterop/CxxWrap.jl#breaking-changes-in-v016). We thus need to

Or am I forgetting something? The one thing I am (again) not sure about is what to do about the version for https://github.com/sloede/openfhe-julia: Technically, we did not change anything but just recompile it against a newer dependency. On the other hand, because it is strictly tied to CxxWrap.jl, if we do not bump the version as well, we might get a newer version of libcxxwrap-julia with an older version of CxxWrap.jl and then boom! - nothing works. We could now

  1. Bump openfhe-julia to v0.4, i.e., create a breaking release, to avoid mismatches.
    Downside: it's a new version without any changes in openfhe-julia itself, thus we only bump the version of compatibility reasons with another package.
  2. Bump only openfhe_julia_jll to v0.4, i.e., create a breaking release, to avoid mismatches.
    Downside: openfhe_julia_jll and openfhe-julia versions do not match anymore, potentially causing confusion.
  3. Do not change any version at all, since technically we did not change anything on our end.
    Downside: If people use OpenFHE.jl with anything but the latest version of the openfhe_julia_jll package, they get crashes.

@ArseniyKholod What's your take on this?

@ArseniyKholod
Copy link
Collaborator

So, if I understood correctly from the slack, Bart thinks, that it is enough to bump openfhe-julia to 0.3.1 and set new compatible version of libcxxwrap-julia to 0.13, update it on Yggdrasil. Then set new patch version of OpenFHE.jl with CxxWrap v0.16 and openfhe-julia 0.3.1 or older. I'm not really good in versioning yet, but it sounds logical, to release next minimal possible version with new compat settings

@ArseniyKholod
Copy link
Collaborator

Should I try this?

@sloede
Copy link
Member Author

sloede commented Jun 11, 2024

Should I try this?

Yes please 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants