[FEAT] 스포츠 전체 조회 기능 구현 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldk980130
approved these changes
Feb 14, 2024
Comment on lines
+11
to
+28
| @TestConfiguration | ||
| public class RestDocsConfig { | ||
|
|
||
| private static final OperationRequestPreprocessor HOST_INFO = preprocessRequest(modifyUris() | ||
| .scheme("https" ) | ||
| .host("www.api.hufstreaming.site" ) | ||
| .removePort(), prettyPrint() | ||
| ); | ||
|
|
||
| @Bean | ||
| public RestDocumentationResultHandler restDocsMockMvcConfigurationCustomizer() { | ||
| return MockMvcRestDocumentation.document( | ||
| "{class-name}/{method-name}", | ||
| HOST_INFO, | ||
| preprocessResponse(prettyPrint()) | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
위처럼 RestDocumentationResultHandler를 빈으로 등록하고 사용할 곳에서 주입 받아서 사용하면 문서들이 생겨나네요. 저도 정확한 오류 원인은 잘 모르겠지만 빈으로 등록해야 완전하게 동작하나봅니다
@Autowired
protected RestDocumentationResultHandler restDocsHandler;There was a problem hiding this comment.
그때는 되고 지금은 안된다니 . . 당혹스럽네요
해결 감사합니닷 👍🏻🫡
ldk980130
reviewed
Feb 14, 2024
Comment on lines
20
to
21
| @Test | ||
| void 모든_종목을_조회한다() { |
There was a problem hiding this comment.
스포츠, 종목에 대한 코멘트는 여기다가 남길게요. 확실히 영어이름은 Sport인데 한글로는 스포츠 또는 종목으로 혼용하고 있네요. 축구, 농구 등을 생각했을 땐 스포츠가 적절해보이지만 루미큐브 같은 경우는 스포츠라 볼 수 있는지 애매하긴 하네요.
종목이 더 포괄적인 의미를 담고 있는 것 같긴한데 용어 통일을 해야한다면 현재로서는 스포츠가 더 적절한것 같긴해요.
There was a problem hiding this comment.
넵 확인했습니당
스포츠로 용어 통일하도록 할게요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌍 이슈 번호
📝 구현 내용
🍀 확인해야 할 부분