[FEAT] 경기 목록 조회 라운드, 팀 아이디로도 조회할 수 있도록 수정 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jin409
changed the title
ldk980130
approved these changes
Mar 1, 2024
Comment on lines
+41
to
+44
| .and(() -> game.sport.id.in(gamesQueryRequestDto.getSportIds())) | ||
| .and(() -> game.round.in(gamesQueryRequestDto.getRound())) | ||
| .and(() -> game.id.in( | ||
| gameTeamDynamicRepository.findAllByLeagueTeamIds(gamesQueryRequestDto.getLeagueTeamIds()))); |
There was a problem hiding this comment.
엄청 복잡한 쿼리 괴물이 만들어지는 중... ㅋㅋㅋㅋㅋ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌍 이슈 번호
📝 구현 내용
🍀 확인해야 할 부분
GamesQueryConditionMapper.mapOrderCondition()를 우선 뒀는데 삭제할까요 아니면 그대로 두는 게 나을까요?