-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEL] 필요 없는 order 관련 로직 및 필드 삭제 #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldk980130
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
삭제 작업 수고하셨습니다!
GameTeamServiceUtils가 아직 남아있던데 확인해보니 더이상 사용되는 곳이 없더라구요. 이 클래스까지 지우고 나서 머지하면 될 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌍 이슈 번호
📝 구현 내용
🍀 확인해야 할 부분
GameQueryAcceptanceTest
가 라인업 관련 로직을 포함하고 있어서 우선은GameQueryServiceTest
에 라인업 테스트 로직도 포함해뒀어요. 그런데query.application
에는 게임 조회 로직은GameQueryService
에, 라인업 관련 로직은LineupPlayerQueryService
에 포함되어 있어서 기준이 명확하지 않다는 생각이 드네요..! 어떻게 통일하는 게 좋을까요?GameTeamServiceUtils
를 삭제할까요? 아니면 혹시 모르니.. 그대로 둘까요?